[Identity] Increment versions after the recent release #16342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadasant
requested review from
0rland0Wats0n,
ankitarorabit,
chradek,
deyaaeldeen,
DominikMe,
EmmaZhu,
HarshaNalluru,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
maorleger,
martinbarnas-ms,
mikeharder,
petrsvihlik,
praveenkuttappan,
ramya-rao-a,
richardpark-msft,
schaabs,
vinjiang,
XiaoningLiu and
a team
as code owners
ghost
added
App Configuration
ghost
added
KeyVault
Storage
| @@ -58,14 +58,11 @@ | |||
| "bugs": { | |||
| "url": "https://github.com/Azure/azure-sdk-for-js/issues" | |||
| }, | |||
| "engine": { | |||
There was a problem hiding this comment.
Is this removal intentioanl? @sadasant
There was a problem hiding this comment.
yes, it seems unnecessary. Let me ask @willmtemple , does it make sense to have both engine and engines? I noticed this in other packages too
There was a problem hiding this comment.
It should just be "engines". I probably copied this from somewhere in our repo that had both.
KarishmaGhiya
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
This looks good to me. There were two places for removing node >=12 from the engine, is that intentional @sadasant ? What exactly does it do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated PR doesn’t exactly work on Identity.
Closes: #16274