Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Event hubs Samples Issue #16666

Closed
v-jiaodi opened this issue Jul 30, 2021 · 4 comments · Fixed by #16945
Closed

Azure Event hubs Samples Issue #16666

v-jiaodi opened this issue Jul 30, 2021 · 4 comments · Fixed by #16945
Assignees
@chradek
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Event Hubs test-manual-pass
Milestone
[2021] September

Comments

@v-jiaodi
Copy link
Member

v-jiaodi commented Jul 30, 2021 •
edited
Loading

Section link1, link2:
image

Reason:
rheaPromise is undefined
Suggestion:
Update rheaPromise to * as rheaPromise.

@lilyjma ,@ramya-rao-a,@chradek and @jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 30, 2021
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @v-jiaodi

@chradek, Do you agree with the recommendation here? If so, @v-jiaodi can send a PR to fix this

@chradek
Copy link
Contributor

chradek commented Aug 5, 2021 •
edited
Loading

Yes, the recommendation seems to fix the issue. I'm surprised because the tsconfig.json has allowSyntheticDefaultImports set to true, so you should be able to do import rheaPromise from 'rheaPromise'.

There do seem to be 2 other issues with the samples though.

  1. It looks like [Identity] Increment versions after the recent release #16342 updated some samples to use an unreleased version of @azure/identity (beta.5). When I tried running npm install on the samples it failed due to this. I plan to revert identity to version 1 in the event hubs samples.
  2. Compiling the project causes an error due to missing @types/ws types. dev-tool was updated in [dev-tool] update samples publish to populate @types/* devDeps #16233 to fix this so the samples just need to be regenerated and that issue should go away.

@v-jiaodi do you want to fix the import issue? Otherwise I can fix that and the other 2 issues this week.

@v-jiaodi
Copy link
Member Author

v-jiaodi commented Aug 5, 2021

Thank you @chradek，It's up to you to fix it.

@ramya-rao-a ramya-rao-a added this to the [2021] September milestone Aug 12, 2021
@ramya-rao-a ramya-rao-a added bug This issue requires a change to an existing behavior in the product in order to be resolved. Docs and removed needs-team-triage Workflow: This issue needs the team to triage. labels Aug 12, 2021
@chradek chradek mentioned this issue Aug 17, 2021
Merged
@chradek
Copy link
Contributor

chradek commented Aug 19, 2021

I created the PR #16945 to fix this.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 28, 2022
@laithhisham @royrein @akning-ms
CodeGen from PR 17924 in Azure/azure-rest-api-specs
4539185 
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>
Co-authored-by: laithhisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Event Hubs test-manual-pass
Projects
None yet
Milestone
[2021] September
Development

Successfully merging a pull request may close this issue.

[event-hubs] fix IoT Connection string sample chradek/azure-sdk-for-js
4 participants
@ramya-rao-a @chradek @v-xuto @v-jiaodi