Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event-hubs] fix IoT Connection string sample #16945

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Aug 17, 2021

Fixes #16666

This PR fixes a couple issues found in the linked issue.

  1. @azure/identity was set to an unreleased beta version. This has been updated to depend on the GA version of @azure/identity.
  2. Updates import rheaPromise from "rhea-promise" to import * as rheaPromise from "rhea-promise", which fixes the rheaPromise is undefined issue.
  3. @types/ws is now included as a dev dependency.

@ramya-rao-a ramya-rao-a merged commit 5944d3a into Azure:main Aug 24, 2021
ckairen pushed a commit to ckairen/azure-sdk-for-js that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Event hubs Samples Issue
2 participants