Removing type validation for errors #19361
Conversation
ghost
added
the
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
| @@ -163,9 +162,6 @@ export async function assertThrowsRestError( | |||
| await testFunction(); | |||
| assert.fail(`${message}: No error thrown`); | |||
| } catch (err) { | |||
| if (!(err instanceof RestError)) { | |||
There was a problem hiding this comment.
Did the pipeline fail because of this line should assert Error instead? The other two look fine to me if we expect them to be Error. Since the code is already merged in main, we could leave them there if they are correct, which would save us from doing it again later when moving to TypeScript v4.4
There was a problem hiding this comment.
min-max pipelines were failing, which is why this PR was needed in the first place.
There was a problem hiding this comment.
I suspect that we were getting some unexpected errors in the min-max testing. It should have passed this check if it's expected. Even if we removed this check, it would fail below. I was thinking that we might want to do instance of Error check here, and let it fail later.
There was a problem hiding this comment.
The main problem with the pipelines was related to this check, err was not an instance of RestError.
I can try checking for instance of Error and see if we don't get the "Error is not recognized" on the pipeline
There was a problem hiding this comment.
I suspect that it is caused by two different versions of core-http in min/max testing. Pushed an update. This hopefully should fix the build.
|
I don't really care about how we are resolving the issue as long as the builds(and live tests) are green. That said, @JonathanCrd can you sync up with @jeremymeng and @KarishmaGhiya to come up with a plan not just for this PR, but also for other SDKs that are/(might be) affected by the same problem? |
This reverts commit 0c6d019.
In min/max testing `instanceof RestError` failed. I suspect that the RestError type and the instance are from two different versions of core-http.
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The sample has been failing for a while and unrelated. Merging. |
|
/check-enforcer override |
Feature/cplat 2022 04 04 (Azure#19467) * set up feature branch * Update cloud service swagger file and examples (Azure#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (Azure#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
CloudService 2022-04-04 release (Azure#19468) * set up branch * Feature/cplat 2022 04 04 (Azure#19467) * set up feature branch * Update cloud service swagger file and examples (Azure#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (Azure#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> * prettier fix Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Fixes: #19355
Removing the type validation for the errors since they are not needed with the current typescript version and they were introduced in PR: #19245