Search Document - test against multiple service versions #19740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
jeremymeng,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
|
/azp run js - search - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sarangan12
changed the title
|
/azp run js - search - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xirzec
approved these changes
Jan 10, 2022
|
/azp run js - search - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Aug 5, 2022
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2022-06-01-preview (Azure#19842) * Adds base for updating Microsoft.MachineLearningServices from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add idleShutdownSetting to Compute Instances (Azure#19748) * Added idleTimeBeforeShutdown to compute instance properties * Added api UpdateIdleShutdownSetting Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * Add mfe.json 2022-06-01-preview changes (Azure#19740) * update mfe.json with 2022-06-01-preview spec * update go.md with preview-2022-06 * add AutoMLJob examples (initial) * add LabelingJob examples (initial) * add Schedule examples (initial) * prettier * update AutoMLJob examples * update LabelingJob examples * update LabelingJob examples * prettier * typo fixes * add Vectorizer to custom-words.txt * add missing * is this a breaking change? * Revert "update go.md with preview-2022-06" This reverts commit b49c64ae0eb258069251c8c13085fd1e5dde56e2. * Updating Swagger Spec for MLC for CustomServices (Azure#19781) * Updating Swagger Spec for MLC for CustomServices * Added Examples * Removing update API in favor of exisiting Patch API and Fixing some Validation issues * Fixed Pretty Issue * Fixed Id Issue * Changed case * Updated Examples * Changing Description * Added nullable fields * Added update APIs * Fixing validation errors * Fix model validation Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> * Add encryption property to workspace update parameters (Azure#19893) * Add encryption property to workspace update parameters Adding the ability for users to update CMK keyIdentifier property for workspace update. * Apply prettier changes Co-authored-by: Joshua Loeffler <jloeffler@microsoft.com> * Add enum value to OutputDataDeliveryMode (Azure#19964) * add soft delete related properties (Azure#19907) * add soft delete related properties * resolve lint diff issue that enum name duplicaton Co-authored-by: Xi Jin <jinxi@microsoft.com> * Remove SoftDeleteEnabled. (Azure#20005) * reorder DeploymentResourceConfiguration Definition (Azure#20057) Co-authored-by: Teddy Todorov <forteddyt@gmail.com> Co-authored-by: teochaban <teochaban@hotmail.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: srivatsasinha <102133347+srivatsasinha@users.noreply.github.com> Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> Co-authored-by: jloeffler7 <102193043+jloeffler7@users.noreply.github.com> Co-authored-by: Joshua Loeffler <jloeffler@microsoft.com> Co-authored-by: XI JIN <giovannijin1990@gmail.com> Co-authored-by: Xi Jin <jinxi@microsoft.com> Co-authored-by: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library(ies) impacted by this PR:
@azure/search-documentsIssue(s) associated with this PR: 17893
Describe the problem(s) that is addressed by this PR:
This PR adds the new
versionToTestmethod from the@azure\test-utilspackage. This new method will test multiple versions of the service, i.e. all the tests will run for multiple service versions instead of one fixed version. The requirement for this task could be found at 17827.What are the possible design(s) available to address the problem(s)
The procedure to enable testing of multiple service versions is standard and documented here
Are there test cases added in this PR?
This PR in itself modifies the test cases. No separate test cases are required.
@xirzec @jeremymeng Please review and approve the PR.
@ramya-rao-a FYI.....