-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Template project to use CoreV2 #19748
Migrate Template project to use CoreV2 #19748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea on the test failure?
@JonathanCrd The test is failing for the case "predetermined setting has expected value". Could you please debug this particular test case and update the PR? |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
@JonathanCrd At this point, just run |
...configurationclient_functional_tests/recording_predetermined_setting_has_expected_value.json
Outdated
Show resolved
Hide resolved
…ndling, and updated metadata const paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please verify that there's no duplicates in the user agent headers in the recordings
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2022-06-01-preview (Azure#19842) * Adds base for updating Microsoft.MachineLearningServices from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add idleShutdownSetting to Compute Instances (Azure#19748) * Added idleTimeBeforeShutdown to compute instance properties * Added api UpdateIdleShutdownSetting Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * Add mfe.json 2022-06-01-preview changes (Azure#19740) * update mfe.json with 2022-06-01-preview spec * update go.md with preview-2022-06 * add AutoMLJob examples (initial) * add LabelingJob examples (initial) * add Schedule examples (initial) * prettier * update AutoMLJob examples * update LabelingJob examples * update LabelingJob examples * prettier * typo fixes * add Vectorizer to custom-words.txt * add missing * is this a breaking change? * Revert "update go.md with preview-2022-06" This reverts commit b49c64ae0eb258069251c8c13085fd1e5dde56e2. * Updating Swagger Spec for MLC for CustomServices (Azure#19781) * Updating Swagger Spec for MLC for CustomServices * Added Examples * Removing update API in favor of exisiting Patch API and Fixing some Validation issues * Fixed Pretty Issue * Fixed Id Issue * Changed case * Updated Examples * Changing Description * Added nullable fields * Added update APIs * Fixing validation errors * Fix model validation Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> * Add encryption property to workspace update parameters (Azure#19893) * Add encryption property to workspace update parameters Adding the ability for users to update CMK keyIdentifier property for workspace update. * Apply prettier changes Co-authored-by: Joshua Loeffler <jloeffler@microsoft.com> * Add enum value to OutputDataDeliveryMode (Azure#19964) * add soft delete related properties (Azure#19907) * add soft delete related properties * resolve lint diff issue that enum name duplicaton Co-authored-by: Xi Jin <jinxi@microsoft.com> * Remove SoftDeleteEnabled. (Azure#20005) * reorder DeploymentResourceConfiguration Definition (Azure#20057) Co-authored-by: Teddy Todorov <forteddyt@gmail.com> Co-authored-by: teochaban <teochaban@hotmail.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: srivatsasinha <102133347+srivatsasinha@users.noreply.github.com> Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> Co-authored-by: jloeffler7 <102193043+jloeffler7@users.noreply.github.com> Co-authored-by: Joshua Loeffler <jloeffler@microsoft.com> Co-authored-by: XI JIN <giovannijin1990@gmail.com> Co-authored-by: Xi Jin <jinxi@microsoft.com> Co-authored-by: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com>
Solves: #18044
This PR migrate
sdk/template/template
from using@azure/core-http
to use@azure/core-client
and@azure/core-rest-pipeline
.Followed instructions on this migration guide
More information about Azure Core V2 can be found here.