Container registry/blob push pull support

[timovv]

Packages impacted by this PR

• @azure/container-registry

Issues associated with this PR

• Fixes [Container Registry] OCI blob push/pull support #20512

Are there test cases added in this PR? (If not, why?)

Yes.

Checklists

• Added impacted package name to the issue description
• Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
• Added a changelog (if necessary)

[azure-sdk]

API changes have been detected in @azure/container-registry. You can review API changes here

[azure-sdk]

API changes have been detected in @azure/container-registry. You can review API changes here

[azure-sdk]

API changes have been detected in @azure/container-registry. You can review API changes here

[azure-sdk]

API changes have been detected in @azure/container-registry. You can review API changes here

[jeremymeng]

Looks good to me! I left some comments, but they can wait.

[azure-sdk]

API change check for @azure/container-registry

API changes have been detected in @azure/container-registry. You can review API changes here

[xirzec]

A few more comments on some things I didn't notice before. I think the public shape looks great modulo the Options interface for the new client.

[xirzec]

interesting, I don't think we've had to do this in convenience before. I wonder if this is a pattern we should think about how to generalize more.

[xirzec]

Small preference for

Suggested change

	function withRequiredProperty<T, U extends keyof T>(property: U, obj: T): T & Required<Pick<T, U>> {
	if (!Object.prototype.hasOwnProperty.call(obj, property)) {
	throw new RestError(`Expected property ${property} to be defined.`);
	}
	return obj as T & Required<Pick<T, U>>;
	}
	function assertRequiredProperty<T, U extends keyof T>(property: U, obj: T): asserts obj is T & Required<Pick<T, U>> {
	if (!Object.prototype.hasOwnProperty.call(obj, property)) {
	throw new RestError(`Expected property ${property} to be defined.`);
	}
	}

so you can use it like

const result = await this.client.containerRegistry.createManifest(
    this.repositoryName,
    tagOrDigest,
    manifestBody,
    { contentType: KnownManifestMediaType.OciManifestMediaType, ...updatedOptions }
  )
);
assertRequiredProperty("dockerContentDigest", result);

return { digest: result.dockerContentDigest };

Mostly because nesting the 'await' inside of a method call seems like an easy way to forget to do it later, and then we're asserting on a Promise object instead of the real result.

[xirzec]

Thanks for the updates!