[ACR] Remove accidental samples-dev/index.ts #21216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
timovv
changed the title
|
API change check for API changes are not detected in this pull request for |
deyaaeldeen
approved these changes
Apr 5, 2022
jeremymeng
approved these changes
Apr 7, 2022
|
any ideas why credscan failed. @sima-zhu? |
|
/azp run js - containerregistry - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We have the check of empty file. It is weird that it doesn't work well in this case. |
|
I have a fix for this: Azure/azure-sdk-tools#3123 |
|
/check-enforcer override |
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Apr 11, 2022
Failed pipeline: Azure/azure-sdk-for-js#21216 https://dev.azure.com/azure-sdk/public/_build/results?buildId=1497101&view=logs&j=bc67675d-56bf-581f-e0a2-208848ba68ca&t=7eee3a58-6120-518b-7fcb-7e943712aa81 The test is based on move the variable out of if condition and check the syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/container-registryDescribe the problem that is addressed by this PR
In #20529 I seem to have accidentally dropped an empty file into
samples-dev. This PR removes the file, so samples build properly.