-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update code owners for Cosmos SDK #22990
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronniegeraghty, would you mind verifying that the bot rules are in-sync for this?
/check-enforcer override |
@jsquire Should the bot rules for issues be sync with this change, even though this change is for the PR Label? |
@ronniegeraghty - what are the current bot rules for cosmos issues for this repo? |
@kushagraThapar Right now, the bot rules for Cosmos mention "simorenoh", "sajeetharan", and "pjohari-ms" when an issue has the "Service Attention" and "Cosmos" labels. |
@ronniegeraghty - can we please change this list to -> |
Sure thing. Change awaiting PR approval #23034 |
### Packages impacted by this PR Health Insights CancerProfilingRest and ClinicalMatchingRest (new packages). ### Issues associated with this PR [[Cognitive Services - Health Decision Support] REST API Review · Issue #5731 · Azure/azure-rest-api-specs-pr (github.com)](Azure/azure-rest-api-specs-pr#5731) ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Provide a list of related PRs _(if any)_ [[Cognitive Services - Health Insights] CADL revision for public preview by asaflevi-ms · Pull Request #22990 · Azure/azure-rest-api-specs (github.com)](Azure/azure-rest-api-specs#22990) --------- Co-authored-by: Asaf Levi <asaflevi@microsoft.com> Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
### Packages impacted by this PR Health Insights CancerProfilingRest and ClinicalMatchingRest (new packages). ### Issues associated with this PR [[Cognitive Services - Health Decision Support] REST API Review · Issue #5731 · Azure/azure-rest-api-specs-pr (github.com)](Azure/azure-rest-api-specs-pr#5731) ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Provide a list of related PRs _(if any)_ [[Cognitive Services - Health Insights] CADL revision for public preview by asaflevi-ms · Pull Request #22990 · Azure/azure-rest-api-specs (github.com)](Azure/azure-rest-api-specs#22990) --------- Co-authored-by: Asaf Levi <asaflevi@microsoft.com> Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
Packages impacted by this PR
N/A
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
Updating code owners from the Cosmos DB team
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists