[Schema Registry] Add getSchemaByVersion #23162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
lmazuel,
conniey,
JoshLove-msft and
swathipil
ghost
added
the
| ); | ||
|
|
||
| // Get definition of existing schema by its ID | ||
| const foundSchema = await client.getSchema(id); |
There was a problem hiding this comment.
This seems to not be getting by the version.
|
Looks like you need to add tests. |
JoshLove-msft
approved these changes
Sep 9, 2022
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
swathipil
reviewed
Sep 9, 2022
sdk/schemaregistry/schema-registry/samples-dev/getSchemaByVersion.ts
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Sep 9, 2022
deyaaeldeen
requested review from
bterlson,
xirzec and
jeremymeng
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows Azure/azure-sdk-for-python#26055
Fixes #23122
TODO:
added tests