Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SchemaRegistry] add support for getting schema by version #26055

Merged
13 commits merged into from
Sep 14, 2022

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Sep 6, 2022

Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically:

  • Adding the get_schema_by_version methods on the sync and async clients.
  • Adding version ivar to the SchemaProperties model.

TODO:

  • add tests
  • update README, samples README, and changelog

addressing: #25072
fixes: #26180

@ghost ghost added the Schema Registry label Sep 6, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-schemaregistry

@swathipil swathipil marked this pull request as ready for review September 13, 2022 18:20
@swathipil
Copy link
Member Author

/azp run python - schemaregistry - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost
Copy link

ghost commented Sep 14, 2022

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 376224e into Azure:main Sep 14, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically:
- Adding the `get_schema_by_version` methods on the sync and async clients.
- Adding `version` ivar to the `SchemaProperties` model.

TODO:
- [x] add tests
- [x] update README, samples README, and changelog

addressing: Azure#25072
fixes: Azure#26180
ghost pushed a commit that referenced this pull request Sep 28, 2022
OOB discussion with Johan:
* Remove `get_schema_by_version` method from sync and async SchemaRegistryClient
* Add `get_schema` overload, which takes `group_name`, `name`, and `version` as keyword args.

Addressing: #25072
Follow up from: #26055
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 24, 2023
microsoft.chaos 2023-10-27-preview (Azure#26101)

* Adds base for updating Microsoft.Chaos from version preview/2023-09-01-preview to version 2023-10-27-preview

* Updates readme

* Updates API version in new specs and examples

* update directive on the open api spec (Azure#26056)

Co-authored-by: James Duan <jduan@microsoft.com>

* Adds an optional object property `customerDataStorage` to the `Microsoft.Chaos/experiments` resource-type (Azure#26055)

* updated provisioningState (Azure#26080)

* updated provisioningState

* prettier fixes

* Add PrivateAccesses Resource (Azure#26035)

* Update privateAccesses.json

* Update privateAccesses Type

* Delete specification/privateAccesses.json

* Update privateAccesses type

* Update examples for privateAccesses

* Update readme.md

* Use v5 common types

* Remove unused definitions

* Remove Patch operation

* change status code for delete

* use custom definition

* use custom list definition

* Use all custom definitions

* Add new definitions

* Add provisioningState for some examples

* Update status code

* Resolve comments

* Remove 200 status code for long-running operation

* Update status code

* Clean definition for resources

* Final fix

* Add needed status code

* Add 200 for sync delete

* updated createUpdateExperiment (Azure#26100)

* updated createUpdateExperiment

* prettier

* Update async delete result code (Azure#26176)

Add 204 as result code for async delete.

* address PR review comment (Azure#26193)

Co-authored-by: James Duan <jduan@microsoft.com>

* Brrusino/experiment create update fix (Azure#26177)

* updated createUpdateExperiment

* prettier

---------

Co-authored-by: James Duan <jduan@microsoft.com>
Co-authored-by: Ritchie Hughes <ritchie.hughes@microsoft.com>
Co-authored-by: Brent Rusinow <44413020+brrusino@users.noreply.github.com>
Co-authored-by: RayY-96 <138829346+RayY-96@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SchemaRegistry] avroencoder - reserved type name in record no longer raises error in avro 1.11.1
5 participants