-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SchemaRegistry] add support for getting schema by version #26055
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run python - schemaregistry - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/schemaregistry/azure-schemaregistry-avroencoder/tests/test_avro_encoder.py
Outdated
Show resolved
Hide resolved
sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_schema_registry_client.py
Outdated
Show resolved
Hide resolved
sdk/schemaregistry/azure-schemaregistry/tests/test_schema_registry.py
Outdated
Show resolved
Hide resolved
...chemaregistry/azure-schemaregistry/azure/schemaregistry/aio/_schema_registry_client_async.py
Outdated
Show resolved
Hide resolved
...chemaregistry/azure-schemaregistry/samples/async_samples/sample_code_schemaregistry_async.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically: - Adding the `get_schema_by_version` methods on the sync and async clients. - Adding `version` ivar to the `SchemaProperties` model. TODO: - [x] add tests - [x] update README, samples README, and changelog addressing: Azure#25072 fixes: Azure#26180
microsoft.chaos 2023-10-27-preview (Azure#26101) * Adds base for updating Microsoft.Chaos from version preview/2023-09-01-preview to version 2023-10-27-preview * Updates readme * Updates API version in new specs and examples * update directive on the open api spec (Azure#26056) Co-authored-by: James Duan <jduan@microsoft.com> * Adds an optional object property `customerDataStorage` to the `Microsoft.Chaos/experiments` resource-type (Azure#26055) * updated provisioningState (Azure#26080) * updated provisioningState * prettier fixes * Add PrivateAccesses Resource (Azure#26035) * Update privateAccesses.json * Update privateAccesses Type * Delete specification/privateAccesses.json * Update privateAccesses type * Update examples for privateAccesses * Update readme.md * Use v5 common types * Remove unused definitions * Remove Patch operation * change status code for delete * use custom definition * use custom list definition * Use all custom definitions * Add new definitions * Add provisioningState for some examples * Update status code * Resolve comments * Remove 200 status code for long-running operation * Update status code * Clean definition for resources * Final fix * Add needed status code * Add 200 for sync delete * updated createUpdateExperiment (Azure#26100) * updated createUpdateExperiment * prettier * Update async delete result code (Azure#26176) Add 204 as result code for async delete. * address PR review comment (Azure#26193) Co-authored-by: James Duan <jduan@microsoft.com> * Brrusino/experiment create update fix (Azure#26177) * updated createUpdateExperiment * prettier --------- Co-authored-by: James Duan <jduan@microsoft.com> Co-authored-by: Ritchie Hughes <ritchie.hughes@microsoft.com> Co-authored-by: Brent Rusinow <44413020+brrusino@users.noreply.github.com> Co-authored-by: RayY-96 <138829346+RayY-96@users.noreply.github.com>
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically:
get_schema_by_version
methods on the sync and async clients.version
ivar to theSchemaProperties
model.TODO:
addressing: #25072
fixes: #26180