-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a function for fetching schema from Schema Registry using group name, schema name and schema version. #25072
Comments
Hi @harshdeep78singh, thank you for opening an issue! I'll tag the appropriate folks so we can answer your question about the potential availability of this API. As for opening a pull request, we're always happy to accept PRs 🙂 For something like adding a client method there will need to be some design discussion, but opening a PR could kickstart that conversation! I'd recommend waiting just a bit before doing any work so that someone who works with the service can provide some input in this case. |
Hi @harshdeep78singh - Thanks for bringing this to our attention! I have discussed this with the team and we will be adding this functionality asap. I saw that you created a PR and took a look. Unfortunately, we will not be able to merge this, because the changes you made were to our "generated" code. This code is automatically generated from our internal "swagger" file that describes operations that we allow. So, ultimately, the changes that you made will actually be added upon re-generation after we update our swagger file to match. Really appreciate your efforts here, however. We are currently making changes to the swagger file and will be having API design discussions after that. I'll keep you updated as we continue to make progress. Thanks again! |
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically: - Adding the `get_schema_by_version` methods on the sync and async clients. - Adding `version` ivar to the `SchemaProperties` model. TODO: - [x] add tests - [x] update README, samples README, and changelog addressing: #25072 fixes: #26180
Hi @harshdeep78singh - Appreciate your patience here! I just merged the feature,(sample [here]), and it'll be out in our next release. I'll update this issue as soon as it's out. In the meantime, if you're interested, you can manually build and install the wheel:
Thanks! |
@swathipil thank you for the update |
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically: - Adding the `get_schema_by_version` methods on the sync and async clients. - Adding `version` ivar to the `SchemaProperties` model. TODO: - [x] add tests - [x] update README, samples README, and changelog addressing: Azure#25072 fixes: Azure#26180
Hey @harshdeep78singh! After a review from our architects, the API to get schema by version has been updated. Rather than a separate As mentioned in a previous comment, you can build the wheel for this package manually. I will also update this issue after this feature has been released. Thanks! |
azure-schemaregistry 1.2.0 has been released: https://pypi.org/project/azure-schemaregistry/1.2.0 |
Currently, I am fetching the schema from the Schema Registry using the following endpoint
/$schemaGroups/{groupName}/schemas/{schemaName}/versions/{version}
There is no function provided in the azure.schemaregistry.SchemaRegistryClient class for pulling the schema from Event Hub Schema Registry using group name, schema name, and version.
Can we have a function for the same?
Also, let me know if you are open to a PR?
The text was updated successfully, but these errors were encountered: