Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SchemaRegistry] overload get schema to take version #26478

Merged
11 commits merged into from
Sep 28, 2022

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Sep 27, 2022

OOB discussion with Johan:

  • Remove get_schema_by_version method from sync and async SchemaRegistryClient
  • Add get_schema overload, which takes group_name, name, and version as keyword args.

Addressing: #25072
Follow up from: #26055

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-schemaregistry

@swathipil swathipil requested a review from johanste September 27, 2022 18:10
Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions that are probably a result of me not understanding Python 😆
But based on the samples, it all looks good.

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 happy to see all languages aligned

@ghost
Copy link

ghost commented Sep 28, 2022

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 72c3dca into Azure:main Sep 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants