-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SchemaRegistry] overload get schema to take version #26478
[SchemaRegistry] overload get schema to take version #26478
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
...chemaregistry/azure-schemaregistry/azure/schemaregistry/aio/_schema_registry_client_async.py
Show resolved
Hide resolved
...chemaregistry/azure-schemaregistry/azure/schemaregistry/aio/_schema_registry_client_async.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions that are probably a result of me not understanding Python 😆
But based on the samples, it all looks good.
sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_schema_registry_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 happy to see all languages aligned
sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_schema_registry_client.py
Outdated
Show resolved
Hide resolved
...aregistry/azure-schemaregistry/azure/schemaregistry/_generated/aio/operations/_operations.py
Show resolved
Hide resolved
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
OOB discussion with Johan:
get_schema_by_version
method from sync and async SchemaRegistryClientget_schema
overload, which takesgroup_name
,name
, andversion
as keyword args.Addressing: #25072
Follow up from: #26055