Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SchemaRegistry] avroencoder - reserved type name in record no longer raises error in avro 1.11.1 #26180

Closed
swathipil opened this issue Sep 13, 2022 · 2 comments · Fixed by #26055
Closed

[SchemaRegistry] avroencoder - reserved type name in record no longer raises error in avro 1.11.1 #26180

swathipil opened this issue Sep 13, 2022 · 2 comments · Fixed by #26055
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Schema Registry
Milestone
2022-10

Comments

@swathipil
Copy link
Member

  • Package Name: azure-schemaregistry-avroencoder
  • Package Version: 1.0.0
  • Operating System: Windows
  • Python Version: 3.10

Describe the bug
With avro==1.11.1, the following test case no longer raises an InvalidSchemaError as it did with avro==1.10.1:

azure-sdk-for-python/sdk/schemaregistry/azure-schemaregistry-avroencoder/tests/test_avro_encoder.py

Line 441 in 244b26c

with pytest.raises(InvalidSchemaError):

To Reproduce
Steps to reproduce the behavior:

  1. Run the specified test case with avro==1.11.0, then avro==1.11.1.

Expected behavior
Figure out how to deal with the discrepancy.
@swathipil swathipil added Client This issue points to a problem in the data-plane of the library. Schema Registry Messaging Messaging crew labels Sep 13, 2022
@swathipil swathipil added this to the Backlog milestone Sep 13, 2022
@swathipil swathipil self-assigned this Sep 13, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2022
@swathipil swathipil mentioned this issue Sep 13, 2022
Merged
2 tasks
@azure-sdk azure-sdk added Container Registry needs-team-triage Workflow: This issue needs the team to triage. labels Sep 13, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2022
@swathipil swathipil modified the milestones: Backlog, 2022-10 Sep 13, 2022
@xiangyan99 xiangyan99 removed the needs-team-triage Workflow: This issue needs the team to triage. label Sep 13, 2022
@swathipil
Copy link
Member Author

swathipil commented Sep 13, 2022 •
edited
Loading

allowed names were changed in version 1.11.1: https://github.com/apache/avro/pull/1533/files

  • previously complex names were restricted. In 1.11.1, only primitive type names are restricted.
  • [here] is the issue tracking this decision

@swathipil
Copy link
Member Author

According to the issue listed above, this was an intentional decision. Bumping the avro min dependency for the avroencoder.

@ghost ghost closed this as completed in #26055 Sep 14, 2022
ghost pushed a commit that referenced this issue Sep 14, 2022
@swathipil
[SchemaRegistry] add support for getting schema by version (#26055)
376224e 
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically:
- Adding the `get_schema_by_version` methods on the sync and async clients.
- Adding `version` ivar to the `SchemaProperties` model.

TODO:
- [x] add tests
- [x] update README, samples README, and changelog

addressing: #25072
fixes: #26180
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this issue Sep 22, 2022
@swathipil @mccoyp
[SchemaRegistry] add support for getting schema by version (Azure#26055)
94cd6b7 
Service already supports getting schema by version and this operation has been added to the swagger. This PR regenerates from that swagger and adds support for this feature. Specifically:
- Adding the `get_schema_by_version` methods on the sync and async clients.
- Adding `version` ivar to the `SchemaProperties` model.

TODO:
- [x] add tests
- [x] update README, samples README, and changelog

addressing: Azure#25072
fixes: Azure#26180
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Schema Registry
Projects
None yet
Milestone
2022-10
Development

Successfully merging a pull request may close this issue.

[SchemaRegistry] add support for getting schema by version swathipil/azure-sdk-for-python
3 participants
@xiangyan99 @azure-sdk @swathipil