Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Respect TryTimeout when opening next available session link #26056

Closed
JoshLove-msft opened this issue Sep 6, 2022 · 0 comments · Fixed by #30832
Closed

[Service Bus] Respect TryTimeout when opening next available session link #26056

JoshLove-msft opened this issue Sep 6, 2022 · 0 comments · Fixed by #30832
Assignees
@kashifkhan
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus

Comments

@JoshLove-msft
Copy link
Member

The service hardcodes a max of 1 minute and 5 seconds when accepting a session. This means the TryTimeout that the user specifies in the client is ignored if they specify a value higher than this. We should specify the timeout property in the link settings properties when opening a link for next available session to support long polling. In the .NET library, we've found that using long polling results in better resource usage and avoids CPU spikes.

.NET fix - Azure/azure-sdk-for-net#30963
@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Sep 6, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 6, 2022
@xiangyan99 xiangyan99 removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 6, 2022
@kashifkhan kashifkhan added the Messaging Messaging crew label Jan 13, 2023
@l0lawrence l0lawrence mentioned this issue Jun 21, 2023
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Oct 24, 2023
@ritchiehughes @brrusino @RayY-96
CodeGen from PR 26101 in Azure/azure-rest-api-specs
c610c6c 
microsoft.chaos 2023-10-27-preview (Azure#26101)

* Adds base for updating Microsoft.Chaos from version preview/2023-09-01-preview to version 2023-10-27-preview

* Updates readme

* Updates API version in new specs and examples

* update directive on the open api spec (Azure#26056)

Co-authored-by: James Duan <jduan@microsoft.com>

* Adds an optional object property `customerDataStorage` to the `Microsoft.Chaos/experiments` resource-type (Azure#26055)

* updated provisioningState (Azure#26080)

* updated provisioningState

* prettier fixes

* Add PrivateAccesses Resource (Azure#26035)

* Update privateAccesses.json

* Update privateAccesses Type

* Delete specification/privateAccesses.json

* Update privateAccesses type

* Update examples for privateAccesses

* Update readme.md

* Use v5 common types

* Remove unused definitions

* Remove Patch operation

* change status code for delete

* use custom definition

* use custom list definition

* Use all custom definitions

* Add new definitions

* Add provisioningState for some examples

* Update status code

* Resolve comments

* Remove 200 status code for long-running operation

* Update status code

* Clean definition for resources

* Final fix

* Add needed status code

* Add 200 for sync delete

* updated createUpdateExperiment (Azure#26100)

* updated createUpdateExperiment

* prettier

* Update async delete result code (Azure#26176)

Add 204 as result code for async delete.

* address PR review comment (Azure#26193)

Co-authored-by: James Duan <jduan@microsoft.com>

* Brrusino/experiment create update fix (Azure#26177)

* updated createUpdateExperiment

* prettier

---------

Co-authored-by: James Duan <jduan@microsoft.com>
Co-authored-by: Ritchie Hughes <ritchie.hughes@microsoft.com>
Co-authored-by: Brent Rusinow <44413020+brrusino@users.noreply.github.com>
Co-authored-by: RayY-96 <138829346+RayY-96@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kashifkhan kashifkhan

Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ServiceBus] set timeout on link properties l0lawrence/azure-sdk-for-python
3 participants
@kashifkhan @xiangyan99 @JoshLove-msft