Pass client timeout to server when accepting next session #30963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Sep 6, 2022
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
jsquire
approved these changes
Sep 6, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpConnectionScope.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpConnectionScope.cs
Show resolved
Hide resolved
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
conniey
reviewed
Sep 7, 2022
| @@ -72,6 +72,13 @@ internal class AmqpConnectionScope : TransportConnectionScope | |||
| /// </summary> | |||
| private static int AuthorizationBaseJitterSeconds { get; } = 30; | |||
|
|
|||
| ///// <summary> | |||
There was a problem hiding this comment.
I think there may have accidentally been more forward-slashes than you wanted
There was a problem hiding this comment.
Ugh.. This is from when I was testing something and had commented out the new property.
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Sep 13, 2022
This is ported from .NET PR Azure/azure-sdk-for-net#30963 he service hardcodes a max of 1 minute and 5 seconds when accepting a session. This means the retry timeout the user specifies in the client is ignored if they specify a value higher than this. We should specify the timeout property in the link settings properties when opening a link for next available session to support long polling.
jeremymeng
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 15, 2022
This is ported from .NET PR Azure/azure-sdk-for-net#30963 The service hardcodes a max of 1 minute and 5 seconds when accepting a session. This means the retry timeout the user specifies in the client is ignored if they specify a value higher than this. We should specify the timeout property in the link settings properties when opening a link for next available session to support long polling.
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* Pass client timeout to server when accepting next session * Fix test * Avoid logging error for link abort * await using * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30962