[Storage][File] use sourceConditions field name in public API #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
HarshaNalluru,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
jeremymeng
force-pushed
the
file-source-conditions
branch
from
507895a to
c3807e9
Compare
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XiaoningLiu
approved these changes
Oct 21, 2019
for consistency with Blob. In PR Azure#5672 we adopted the field names `conditions` and `sourceConditions`. This change fixes the only place in File where `SourceModifiedAccessConditions` is used in public API to be consistent.
chradek
force-pushed
the
file-source-conditions
branch
from
c3807e9 to
fb9ebf0
Compare
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for consistency with Blob.
In PR #5672 we adopted the field names
conditionsandsourceConditions.This change fixes the only place in File where
SourceModifiedAccessConditionsis used in public API to be consistent.