Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage][File] use sourceConditions field name in public API #5682

Merged
merged 1 commit into from
Oct 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions sdk/storage/storage-file/src/FileClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
FileSetHTTPHeadersResponse,
FileSetMetadataResponse,
FileStartCopyResponse,
FileUploadRangeFromURLOptionalParams,
SourceModifiedAccessConditions,
FileUploadRangeFromURLResponse,
FileUploadRangeResponse,
HandleItem,
Expand Down Expand Up @@ -220,9 +220,7 @@ export interface FileUploadRangeOptions extends CommonOptions {
* @export
* @interface FileUploadRangeFromURLOptions
*/
export interface FileUploadRangeFromURLOptions
extends FileUploadRangeFromURLOptionalParams,
CommonOptions {
export interface FileUploadRangeFromURLOptions extends CommonOptions {
/**
* An implementation of the `AbortSignalLike` interface to signal the request to cancel the operation.
* For example, use the @azure/abort-controller to create an `AbortSignal`.
Expand All @@ -231,6 +229,20 @@ export interface FileUploadRangeFromURLOptions
* @memberof FileUploadRangeFromURLOptions
*/
abortSignal?: AbortSignalLike;
/**
* The timeout parameter is expressed in seconds. For more information, see <a
* href="https://docs.microsoft.com/en-us/rest/api/storageservices/Setting-Timeouts-for-File-Service-Operations?redirectedfrom=MSDN">Setting
* Timeouts for File Service Operations.</a>
*/
timeoutInSeconds?: number;
/**
* Specify the crc64 calculated for the range of bytes that must be read from the copy source.
*/
sourceContentCrc64?: Uint8Array;
/**
* Additional parameters for the operation
*/
sourceConditions?: SourceModifiedAccessConditions;
}

/**
Expand Down Expand Up @@ -1200,6 +1212,7 @@ export class FileClient extends StorageClient {
0,
{
abortSignal: options.abortSignal,
sourceModifiedAccessConditions: options.sourceConditions,
...options,
spanOptions
}
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/storage-file/src/generatedModels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,6 @@ export {
ShareSetAccessPolicyResponse,
ShareSetMetadataResponse,
ShareSetQuotaResponse,
SignedIdentifier as SignedIdentifierModel
SignedIdentifier as SignedIdentifierModel,
SourceModifiedAccessConditions
} from "./generated/src/models";