-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-tracing] Update to OpenTelemetry 0.6 #7998
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
113e8e4
Move to core-tracing to OpenTelemetry 0.5
xirzec 513a49a
Migrate all packages to OpenTelemetry 0.5
xirzec 4b4533c
Bump version of core-tracing
xirzec d7d5691
Bump cache version
xirzec 37cb01b
Fixup changelog
xirzec ac2011a
Fix build breaks
xirzec a06d2e5
Fix named export
xirzec f2b1a77
Revert using OT noop
xirzec 8e455ba
fix build break
xirzec 3f4d0f4
Merge remote-tracking branch 'upstream/master' into OT05
xirzec 3bb121d
update lockfil
xirzec 2b85d20
Create new tracing interfaces
xirzec f508508
Try to adopt
xirzec 15d6c1c
Fix build breaks
xirzec 2109b5b
Merge remote-tracking branch 'upstream/master' into OT05
xirzec e2d872b
Update lockfile
xirzec 5fa208d
Merge remote-tracking branch 'upstream/master' into OT05
xirzec ad0301d
Update lockfile
xirzec 7cb934f
Merge branch 'master' into OT05
xirzec 5d40a9b
Merge branch 'master' into OT05
xirzec 04e4699
Update lockfile
xirzec 4b49cf7
Fix test break
xirzec d203333
Merge remote-tracking branch 'upstream/master' into OT05
xirzec e53ce32
fixup
xirzec 3bbb73c
update lockfile
xirzec b04875e
Fix identity and search
xirzec 76c875a
Fix form recognizer
xirzec d96896b
Update min version of core-http
xirzec 00be357
Update to OpenTelemetry 0.6.1
xirzec 3fee5c8
Merge remote-tracking branch 'origin' into pr/xirzec/7998
ramya-rao-a a01b8eb
Update sdk/core/core-tracing/CHANGELOG.md
xirzec 0831e8b
Update sdk/core/core-tracing/src/utils/cache.ts
xirzec 938ea38
Merge remote-tracking branch 'upstream/master' into OT05
xirzec 1ed0928
Fix merge conflicts
xirzec e09ff90
Fix broken eventhubs test
xirzec bd0a000
Ensure datalake depends on latest blob
xirzec 3aed715
Merge remote-tracking branch 'upstream/master' into OT05
xirzec ab0796a
Update deps
xirzec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect the parent of a span to also be of type span... this would be one of the things the user can pass in right?
We are changing that now, or was that never the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenTelemetry lets you pass either a
Span
or aSpanContext
. This is mostly for convenience as it is not hard to get the context.However, since
Span
is a much bigger surface area than context, the proposal is to not support direct passing of spans in our options in order to avoid having to risk breaking changes inSpan
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes, this is a breaking change.