-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-tracing] Update to OpenTelemetry 0.6 #7998
Conversation
Would these require all the affected packages to release an update at the same time? Or can a package that has no other changes wait until it has a significant changes to release? Or should we release all packages at once to keep ourselves sane? |
From CI I figured out that open telemetry classes don't support ES5 (IE11). Filed open-telemetry/opentelemetry-js#902 and I'm backing out using their noop implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from storage side
cc @richardpark-msft for EH & SB, @jeremymeng. @bterlson for core-http and core-tracing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in proxy for AppConfig, EH and ServiceBus (assuming we're going to run all the normal tests).
I saw the conversation you had with @ramya-rao-a about how this is a breaking change but I assume this okay because the entire tracing feature is still considered preview.
(also, just to mention - we'll need to run the live tests for EventHubs and ServiceBus as they don't have unit tests at all).
/azp run js - eventhubs-client - tests |
/azp run js - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - appconfiguration - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
"@azure/core-http": "^1.0.0", | ||
"@azure/core-tracing": "1.0.0-preview.7", | ||
"@azure/core-http": "^1.1.1", | ||
"@azure/core-tracing": "1.0.0-preview.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we are releasing Form Recognizer preview.1 tomorrow. Dependency version update for form recognizer should be in after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will get the all-clear from you before merging this PR then.
Looks good to me. Just a note about the timing of the form recognizer preview.1 release tomorrow and merging form recognizer dependency update in this PR. |
/azp run js - eventhubs-client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
This change updates core-tracing to the beta version of OT (0.6.1) in preparation for their GA.
Unfortunately, there are a few breaking changes, so I had to make fixes throughout the code.
This also may impact the min-version we are able to support of core packages due to
OperationOptions
exporting theSpanOptions
type. (/cc @KarishmaGhiya )Fixes #7079