[KeyVault Certificates Hotfix 4.0.1] Commits to make sure the builds work #8842
Conversation
sadasant
force-pushed
the
hotfix/keyvault-challengeAuth-certificates-from-4.0.0-CI-2
branch
from
d487ef0 to
a6a316b
Compare
sadasant
requested review from
danieljurek,
KarishmaGhiya,
mikeharder,
mitchdenny and
weshaggard
as code owners
sadasant
changed the title
sadasant
changed the title
Since this PR doesnt contain the actual hot fix, can we have the PR title updated? |
|
@ramya-rao-a hi! Two minutes before your comment I did this:
Because Jonathan said it could help speed things up to put everything into this PR, so I'm on it. |
sadasant
changed the title
sadasant
changed the title
|
Since we still need to add #7998 to the mix, I think it makes ever more sense to limit this PR to what it currently has. I'll be making new PRs for the rest. |
… integration-test:node command (Azure#6907) * finding the recordings folder to fix the current integration-test command * refactor - move to utils.ts * update as per the refactoring and relativeTestRecordingFilePath rename * add a base case - hitting the root folder * update names as per the feedback
|
@ramya-rao-a while running tests I realized I needed one more cherry-pick commit as part of this PR. I have pushed that commit. Please review again. |
|
Looks like the changes are to the recorder. |
Daniel mentioned that this branch is outdated, and we concluded on cherry-picking the required commit to fix the branch. |
sadasant
merged commit 66794b0
into
Azure:hotfix/keyvault-challengeAuth-certificates-from-4.0.0
sadasant
deleted the
hotfix/keyvault-challengeAuth-certificates-from-4.0.0-CI-2
branch
This PR has what is needed to make the base branch for the challenge based authentication hotfix stable.
The base branch,
hotfix/keyvault-challengeAuth-certificates-from-4.0.0, comes from the commit7c1b8d7f174f90456932acce99b9d0bf49dc197b, which comes from the stable KeyVault release https://github.com/Azure/azure-sdk-for-js/releases/tag/%40azure%2Fkeyvault-certificates_4.0.0I made a couple PRs before this one, but the git history and the builds got weird. This one should be fine.