[KeyVault Keys and Secrets Hotfix 4.0.3] Updating core-http and opentelemetry #8876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
approved these changes
May 12, 2020
Contributor
Author
|
I'm merging this one since we can rely on the status of: #8766 |
sadasant
merged commit 439c725
into
Azure:hotfix/keyvault-challengeAuth-keys-secrets-4.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: #8872
Changes from: https://github.com/Azure/azure-sdk-for-js/pull/7998/files Plus a bunch of other things I had to do.
The upgrade to identity's 1.1.0-preview.3 was suggested by Jeff Fisher, and it worked nicely!
IMPORTANT: KeyVault keys and secrets tests will fail because we have already merged the recordings related to the hotfix to this branch.
CI can possibly still fail from other reasons, so beware of that. I'll make sure it passes though! Just have patience.