Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archboard feedback for CLU 1.0 GA SDK #29331

Closed
15 tasks done
heaths opened this issue Jun 16, 2022 · 2 comments · Fixed by #29340
Closed
15 tasks done

Archboard feedback for CLU 1.0 GA SDK #29331

heaths opened this issue Jun 16, 2022 · 2 comments · Fixed by #29340
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language
Milestone

Comments

@heaths
Copy link
Member

heaths commented Jun 16, 2022

Service:

  • How big do we expect export sizes? Might need another pattern.
  • Talk to service about updating their readme.md with CLU transforms, and about the 200/202 pattern for LROs.

APIView:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 16, 2022
@heaths heaths self-assigned this Jun 16, 2022
@azure-sdk azure-sdk added App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Jun 16, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 16, 2022
@heaths heaths added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Cognitive - Language and removed App Configuration Azure.ApplicationModel.Configuration needs-team-triage Workflow: This issue needs the team to triage. labels Jun 16, 2022
@azure-sdk azure-sdk added the App Configuration Azure.ApplicationModel.Configuration label Jun 16, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 16, 2022
@azure-sdk azure-sdk added the needs-team-triage Workflow: This issue needs the team to triage. label Jun 16, 2022
@heaths heaths added this to the [2022] July milestone Jun 16, 2022
@heaths heaths removed App Configuration Azure.ApplicationModel.Configuration needs-team-triage Workflow: This issue needs the team to triage. labels Jun 16, 2022
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jun 16, 2022
Partial resolution for Azure#29331
@heaths
Copy link
Member Author

heaths commented Jun 16, 2022

See if the service is removing the "status" and "jobId" from the final output.

I opened #29347 to track, which has many more details about this issue.

@heaths
Copy link
Member Author

heaths commented Jun 18, 2022

Had issues with transforming away explicit pageable parameters. Opened Azure/autorest#4565 and Azure/autorest#4566 to track and ended up with a single transform:

directive:
- from: swagger-document
  where: $.paths.*.*
  transform: |
    var paramRefs = [
        "common.json#/parameters/TopParameter",
        "common.json#/parameters/SkipParameter",
        "common.json#/parameters/MaxPageSizeParameter"
    ];
    if (/ConversationalAnalysisAuthoring_((List(Projects|Deployments|TrainedModels|TrainingJobs|TrainingConfigVersions))|Get(ModelEvaluationResults|SupportedLanguages|SupportedPrebuiltEntities))/.test($.operationId)) {
        $.parameters = $.parameters.filter(param => !paramRefs.includes(param["$ref"]));
    }

Not pretty, but it works. Also had to use $.paths.*.* instead of $.paths.. as shown in the Azure/autorest repo in several places because I got an error without the asterisks:

info    |    Loading AutoRest extension '@autorest/modelerfour' (4.23.5->4.23.5)
error   | directive/error | Error occured when running directive: Error: Parse error on line 1:
$.paths..
---------^
Expecting 'STAR', 'IDENTIFIER', 'SCRIPT_EXPRESSION', 'INTEGER', 'END', '[', got '1'

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jun 20, 2022
Partial resolution for Azure#29331
Repository owner moved this from In Progress to Done in Azure SDK for Cognitive Services - Language Jun 20, 2022
heaths added a commit that referenced this issue Jun 20, 2022
* Resolve archboard feedback

Partial resolution for #29331

* Delete local swagger used for testing changes

* Fix Sample5 typo

* Add some recorded tests to check multilingual transform

* Fix tests post-rebase

* Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient

* Remove explicit pageable parameters

...until #29342 is resolved
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this issue Jul 27, 2022
* Resolve archboard feedback

Partial resolution for Azure#29331

* Delete local swagger used for testing changes

* Fix Sample5 typo

* Add some recorded tests to check multilingual transform

* Fix tests post-rebase

* Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient

* Remove explicit pageable parameters

...until Azure#29342 is resolved
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this issue Dec 7, 2022
* Resolve archboard feedback

Partial resolution for Azure#29331

* Delete local swagger used for testing changes

* Fix Sample5 typo

* Add some recorded tests to check multilingual transform

* Fix tests post-rebase

* Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient

* Remove explicit pageable parameters

...until Azure#29342 is resolved
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language
Projects
Development

Successfully merging a pull request may close this issue.

2 participants