-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archboard feedback for CLU 1.0 GA SDK #29331
Comments
Partial resolution for Azure#29331
I opened #29347 to track, which has many more details about this issue. |
Had issues with transforming away explicit pageable parameters. Opened Azure/autorest#4565 and Azure/autorest#4566 to track and ended up with a single transform: directive:
- from: swagger-document
where: $.paths.*.*
transform: |
var paramRefs = [
"common.json#/parameters/TopParameter",
"common.json#/parameters/SkipParameter",
"common.json#/parameters/MaxPageSizeParameter"
];
if (/ConversationalAnalysisAuthoring_((List(Projects|Deployments|TrainedModels|TrainingJobs|TrainingConfigVersions))|Get(ModelEvaluationResults|SupportedLanguages|SupportedPrebuiltEntities))/.test($.operationId)) {
$.parameters = $.parameters.filter(param => !paramRefs.includes(param["$ref"]));
} Not pretty, but it works. Also had to use
|
Partial resolution for Azure#29331
* Resolve archboard feedback Partial resolution for #29331 * Delete local swagger used for testing changes * Fix Sample5 typo * Add some recorded tests to check multilingual transform * Fix tests post-rebase * Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient * Remove explicit pageable parameters ...until #29342 is resolved
* Resolve archboard feedback Partial resolution for Azure#29331 * Delete local swagger used for testing changes * Fix Sample5 typo * Add some recorded tests to check multilingual transform * Fix tests post-rebase * Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient * Remove explicit pageable parameters ...until Azure#29342 is resolved
* Resolve archboard feedback Partial resolution for Azure#29331 * Delete local swagger used for testing changes * Fix Sample5 typo * Add some recorded tests to check multilingual transform * Fix tests post-rebase * Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient * Remove explicit pageable parameters ...until Azure#29342 is resolved
continue
to skip and instead nest theforeach
in anif
.Console.WriteLine
between getting an LRO and waiting on it.WaitUntil.Completed
calls.ConversationAuthoringClient
Get*Status
methods for LROs/VLROs #29332)Get*Status
methods for LROs/VLROs #29332)Service:
APIView:
The text was updated successfully, but these errors were encountered: