Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve archboard feedback for CLU 1.0 GA #29340

Merged
merged 7 commits into from
Jun 20, 2022

Conversation

heaths
Copy link
Member

@heaths heaths commented Jun 16, 2022

Resolves #29331

@heaths heaths requested a review from kristapratico June 16, 2022 18:06
@heaths heaths changed the title clu 1.0 archboard feedback Resolve archboard feedback for CLU 1.0 GA Jun 16, 2022
@heaths heaths requested a review from annelo-msft June 16, 2022 18:07
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.AI.Language.Conversations

@heaths heaths force-pushed the clu-1.0-archboard-feedback branch from eda48cd to 0ebf809 Compare June 17, 2022 21:28
@heaths heaths changed the base branch from release/clu-2022-05-01 to main June 17, 2022 21:31
@heaths heaths linked an issue Jun 17, 2022 that may be closed by this pull request
15 tasks
@heaths heaths marked this pull request as ready for review June 18, 2022 00:49
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@Azure Azure deleted a comment Jun 20, 2022
@heaths heaths force-pushed the clu-1.0-archboard-feedback branch from 164d461 to de53e8f Compare June 20, 2022 21:16
@heaths heaths enabled auto-merge (squash) June 20, 2022 21:17
@heaths
Copy link
Member Author

heaths commented Jun 20, 2022

Merge conflict due to change in LRO protocol method implementation, so just rebased, resolved the conflict, and pushed with The --force.

@heaths
Copy link
Member Author

heaths commented Jun 20, 2022

/check-enforcer reset

@heaths heaths merged commit bbe7123 into Azure:main Jun 20, 2022
@heaths heaths deleted the clu-1.0-archboard-feedback branch June 20, 2022 22:49
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* Resolve archboard feedback

Partial resolution for Azure#29331

* Delete local swagger used for testing changes

* Fix Sample5 typo

* Add some recorded tests to check multilingual transform

* Fix tests post-rebase

* Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient

* Remove explicit pageable parameters

...until Azure#29342 is resolved
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
* Resolve archboard feedback

Partial resolution for Azure#29331

* Delete local swagger used for testing changes

* Fix Sample5 typo

* Add some recorded tests to check multilingual transform

* Fix tests post-rebase

* Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient

* Remove explicit pageable parameters

...until Azure#29342 is resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archboard feedback for CLU 1.0 GA SDK
3 participants