-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve archboard feedback for CLU 1.0 GA #29340
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
eda48cd
to
0ebf809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
Partial resolution for Azure#29331
...until Azure#29342 is resolved
164d461
to
de53e8f
Compare
Merge conflict due to change in LRO protocol method implementation, so just rebased, resolved the conflict, and pushed with The --force. |
/check-enforcer reset |
* Resolve archboard feedback Partial resolution for Azure#29331 * Delete local swagger used for testing changes * Fix Sample5 typo * Add some recorded tests to check multilingual transform * Fix tests post-rebase * Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient * Remove explicit pageable parameters ...until Azure#29342 is resolved
* Resolve archboard feedback Partial resolution for Azure#29331 * Delete local swagger used for testing changes * Fix Sample5 typo * Add some recorded tests to check multilingual transform * Fix tests post-rebase * Rename ConveratinAnalysisProjectsClient to ConversationAuthoringClient * Remove explicit pageable parameters ...until Azure#29342 is resolved
Resolves #29331