Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Identity October Release Doc Consistency Review #31064

Closed
joshfree opened this issue Sep 12, 2022 · 2 comments · Fixed by #31867
Closed

Azure Identity October Release Doc Consistency Review #31064

joshfree opened this issue Sep 12, 2022 · 2 comments · Fixed by #31867
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@joshfree
Copy link
Member

joshfree commented Sep 12, 2022

tracking item for README, Samples, TROUBLESHOOT, and Changelog consistency review

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Sep 12, 2022
@joshfree joshfree added this to the 2022-10 milestone Sep 12, 2022
@pvaneck
Copy link
Member

pvaneck commented Sep 27, 2022

Notable consistency updates:

README

General consistency + issues

  • Add a "Cloud configuration" section (Example)
  • Provide or link to example for ManagedIdentityCredential in "Managed Identity Support" section.
  • Add a "Reference" column to "Credential Class" tables. See this example
  • Sentence-case all headings
  • Replace all occurrences of "docs.microsoft.com" with "learn.microsoft.com"
  • In "Getting Started", "Credential classes", and "Examples", avoid starting headings with "-ing" words when possible
    • s/Authenticating/Authenticate/
    • s/Specifying/Specify/
    • s/Enabling/Enable/
  • Update intro paragraph to one used here
  • Replace subsequent instances of "Azure Active Directory" and "AAD" with "Azure AD" which is the preferred short form.
  • Find and replace: "the Azure Cloud" -> "Azure"
  • Verify if AAD B2C is supported. If so, remove from Known issues section.

TROUBLESHOOTING

Samples

  • .NET seems to be the only SDK without Redis samples.

@joshfree joshfree moved this from Planned to In Progress in Azure Identity SDK Improvements Oct 3, 2022
@pvaneck
Copy link
Member

pvaneck commented Oct 4, 2022

FYI, Reference readme + troubleshooting has been merged: Azure/azure-sdk-for-python#26483
I have notated the majority of the changes that should be made in the above comment. Let me know if additional assistance is needed.

@schaabs schaabs modified the milestones: 2022-10, 2022-11 Oct 13, 2022
pvaneck added a commit to pvaneck/azure-sdk-for-net that referenced this issue Oct 17, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck added a commit to pvaneck/azure-sdk-for-net that referenced this issue Oct 18, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck added a commit that referenced this issue Oct 20, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: #31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Repository owner moved this from In Progress to Done in Azure Identity SDK Improvements Oct 20, 2022
schaabs pushed a commit to schaabs/azure-sdk-for-net that referenced this issue Nov 8, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
schaabs added a commit that referenced this issue Nov 8, 2022
* [Identity] Update documentation (#31867)

This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: #31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* fix error messages with AADSTS and az login (#31949)

* fix error messages with AADSTS and az login

* Update SharedTokenCacheCredential XML class documentation (#32195)

* [Identity] Class documentation improvements (#32043)

This adds additional details to the docstrings for
some of the credential classes. Users may find the
added info helpful.

Also added missing envvar in README.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update Azure.Identity changelog (#32216)

* Handle Managed Identity json parse errors as CredentialUnAvailableException (#32272)

* handle json parse errors as CredentialNotAvailable

* update changelog for 1.8.0 release

* update csproj version

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this issue Dec 7, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants