-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Update documentation #31867
Conversation
This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement. Ref: Azure#31064 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
API change check API changes are not detected in this pull request. |
* Also removed locale from some links Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
This is my review; requested changes were made and I'm removing the block while deferring to others for approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final round of suggestions, and then this PR looks good to me.
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@schaabs Would like to get your review/approval before merging. |
Thanks all for the reviews. :) |
This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement. Code snippets were added for the README. Ref: Azure#31064 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* [Identity] Update documentation (#31867) This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement. Code snippets were added for the README. Ref: #31064 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * fix error messages with AADSTS and az login (#31949) * fix error messages with AADSTS and az login * Update SharedTokenCacheCredential XML class documentation (#32195) * [Identity] Class documentation improvements (#32043) This adds additional details to the docstrings for some of the credential classes. Users may find the added info helpful. Also added missing envvar in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Update Azure.Identity changelog (#32216) * Handle Managed Identity json parse errors as CredentialUnAvailableException (#32272) * handle json parse errors as CredentialNotAvailable * update changelog for 1.8.0 release * update csproj version Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: Christopher Scott <chriss@microsoft.com>
This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement. Code snippets were added for the README. Ref: Azure#31064 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement.
Closes: #31064