Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #35919

Closed
xiangyan99 opened this issue May 1, 2023 · 2 comments · Fixed by #36849
Closed

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #35919

xiangyan99 opened this issue May 1, 2023 · 2 comments · Fixed by #36849
Assignees
@christothes
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
2023-06

Comments

@xiangyan99
Copy link
Member

xiangyan99 commented May 1, 2023 •
edited
Loading

Library name

Azure.Identity

Please describe the feature.

Currently if we find an expired token in shared token credential, we stop attempting next credential.

Let's continue on all dev credentials: do not stop trying with dev credentials until obtaining a valid token or completing the chain
@xiangyan99 xiangyan99 added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 1, 2023
@xiangyan99 xiangyan99 mentioned this issue May 1, 2023
Closed
@xiangyan99
Copy link
Member Author

#35919
Azure/azure-sdk-for-java#34733
Azure/azure-sdk-for-js#25717
Azure/azure-sdk-for-python#30167

This was referenced May 1, 2023
Closed
Closed
@joshfree joshfree added this to the 2023-06 milestone May 1, 2023
@xiangyan99 xiangyan99 changed the title [FEATURE REQ]Revisit DAC: should we not stop on shared token cache credential if we find an expired one DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain May 22, 2023
@xiangyan99
Copy link
Member Author

The Python PR: Azure/azure-sdk-for-python#30441

@christothes christothes mentioned this issue Jun 6, 2023
Merged
@christothes christothes moved this from Planned to In Progress in Azure Identity SDK Improvements Jun 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Jun 13, 2023
@christothes christothes mentioned this issue Jul 19, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christothes christothes

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-06
Development

Successfully merging a pull request may close this issue.

DAC developer credentials fail with CredentialUnavailableException christothes/azure-sdk-for-net
3 participants
@christothes @joshfree @xiangyan99