Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #30167

Closed
xiangyan99 opened this issue May 1, 2023 · 2 comments
Closed

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #30167

xiangyan99 opened this issue May 1, 2023 · 2 comments
Assignees
@xiangyan99
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
2023-06

Comments

@xiangyan99
Copy link
Member

xiangyan99 commented May 1, 2023 •
edited
Loading

Currently if we find an expired token in shared token credential, we stop attempting next credential.

Let's continue on all dev credentials: do not stop trying with dev credentials until obtaining a valid token or completing the chain
@xiangyan99 xiangyan99 self-assigned this May 1, 2023
@xiangyan99 xiangyan99 added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 1, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 1, 2023
@xiangyan99
Copy link
Member Author

Azure/azure-sdk-for-net#35919
Azure/azure-sdk-for-java#34733
Azure/azure-sdk-for-js#25717
#30167

This was referenced May 1, 2023
Closed
Closed
Closed
@joshfree joshfree added this to the 2023-06 milestone May 1, 2023
@xiangyan99 xiangyan99 removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 2, 2023
@joshfree joshfree moved this from Planned to In Progress in Azure Identity SDK Improvements May 22, 2023
@xiangyan99 xiangyan99 changed the title Revisit DAC: should we not stop on shared token cache credential if we find an expired one DAC: do not stop trying with dev credentials until obtaining a valid token or complete the chain May 22, 2023
@xiangyan99 xiangyan99 changed the title DAC: do not stop trying with dev credentials until obtaining a valid token or complete the chain DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain May 22, 2023
@pvaneck pvaneck mentioned this issue Jun 1, 2023
Closed
@xiangyan99 xiangyan99 moved this from In Progress to Done in Azure Identity SDK Improvements Jun 5, 2023
This was referenced Aug 3, 2023
Closed
Closed
@xiangyan99
Copy link
Member Author

Done.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiangyan99 xiangyan99

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-06
Development

No branches or pull requests
2 participants
@joshfree @xiangyan99