Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batch multiPart requests and responses #14275

Merged
merged 17 commits into from
Aug 21, 2020
Merged

Support batch multiPart requests and responses #14275

merged 17 commits into from
Aug 21, 2020

Conversation

christothes
Copy link
Member

No description provided.

@christothes christothes requested a review from pakrym August 17, 2020 19:12
@christothes christothes self-assigned this Aug 17, 2020
@christothes christothes requested a review from tg-msft August 17, 2020 19:14
@tg-msft
Copy link
Member

tg-msft commented Aug 18, 2020

How does this relate to the one we have for Storage at https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/storage/Azure.Storage.Blobs.Batch/src/Shared? Should we change Storage to use this?

@christothes
Copy link
Member Author

christothes commented Aug 18, 2020 •
edited
Loading

How does this relate to the one we have for Storage at https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/storage/Azure.Storage.Blobs.Batch/src/Shared? Should we change Storage to use this?

Yes we should take this dependency in storage- but to do it before the changes propagates to core was a bit messy with the nested package reference.

Tracking in #14388

@christothes christothes mentioned this pull request Aug 19, 2020
Closed
pakrym
pakrym reviewed Aug 19, 2020
View reviewed changes
sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
@@ -216,15 +216,18 @@ public static partial class Names
{
public static string Accept { get { throw null; } }
public static string Authorization { get { throw null; } }
public static string ContentDisposition { get { throw null; } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @KrzysztofCwalina we are adding more header names.

@christothes
Copy link
Member Author

/azp run net - core - ci

@christothes
Copy link
Member Author

/azp run net - tables - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christothes
Copy link
Member Author

/azp run net - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christothes christothes merged commit 551a6d6 into Azure:master Aug 21, 2020
@christothes christothes mentioned this pull request Aug 21, 2020
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Jul 8, 2021
@kairu-ms
CodeGen from PR 14275 in Azure/azure-rest-api-specs
aafe03b 
revert Tables api to version 2020-08 (Azure#14275)

* revert Tables api to version 2020-08

* Update readme.md

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym pakrym pakrym approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees

@christothes christothes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christothes @tg-msft @pakrym