Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch multiPart requests and responses #14275

Merged
merged 17 commits into from
Aug 21, 2020
Merged

Support batch multiPart requests and responses #14275

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bba5269
wip
christothes Aug 10, 2020
d5ca342
wip
christothes Aug 13, 2020
e8404eb
Merge remote-tracking branch 'upstream/master' into users/chriss/tabl…
christothes Aug 13, 2020
1608966
Merge remote-tracking branch 'upstream/master' into users/chriss/tabl…
christothes Aug 17, 2020
9f1f812
support batch multiPart requests and responses
christothes Aug 17, 2020
e8ff4c7
remove RequestContent.Headers
christothes Aug 17, 2020
e549945
remove test mode
christothes Aug 17, 2020
d3db09d
remove HashCodeCombiner
christothes Aug 17, 2020
cc35ee6
remove StringSegment and StringTokenizer
christothes Aug 17, 2020
72ca094
Multipart subdir in shared, remove more types
christothes Aug 17, 2020
8e0baf9
remove consts and error classes
christothes Aug 17, 2020
673a384
explicit line breaks in SendMultipartData test
christothes Aug 18, 2020
459678f
pr comments
christothes Aug 19, 2020
b9cab18
multipart tests
christothes Aug 20, 2020
270a699
merge
christothes Aug 20, 2020
6ed40a1
refactor tests
christothes Aug 20, 2020
ee3fe61
export core
christothes Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,18 @@ public static partial class Names
{
public static string Accept { get { throw null; } }
public static string Authorization { get { throw null; } }
public static string ContentDisposition { get { throw null; } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @KrzysztofCwalina we are adding more header names.

public static string ContentLength { get { throw null; } }
public static string ContentType { get { throw null; } }
public static string Date { get { throw null; } }
public static string ETag { get { throw null; } }
public static string Host { get { throw null; } }
public static string IfMatch { get { throw null; } }
public static string IfModifiedSince { get { throw null; } }
public static string IfNoneMatch { get { throw null; } }
public static string IfUnmodifiedSince { get { throw null; } }
public static string Range { get { throw null; } }
public static string Referer { get { throw null; } }
public static string UserAgent { get { throw null; } }
public static string XMsDate { get { throw null; } }
public static string XMsRange { get { throw null; } }
Expand Down
14 changes: 12 additions & 2 deletions sdk/core/Azure.Core/src/HttpHeader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,19 @@ public static class Names
/// Returns. <code>"If-Unmodified-Since"</code>
/// </summary>
public static string IfUnmodifiedSince => "If-Unmodified-Since";
/// <summary>
/// Returns. <code>"Referer"</code>
/// </summary>
public static string Referer => "Referer";
/// <summary>
/// Returns. <code>"Host"</code>
/// </summary>
public static string Host => "Host";

internal static string Referer => "Referer";
internal static string Host => "Host";
/// <summary>
/// Returns <code>"Content-Disposition"</code>
/// </summary>
public static string ContentDisposition => "Content-Disposition";
}

#pragma warning disable CA1034 // Nested types should not be visible
Expand Down
4 changes: 3 additions & 1 deletion sdk/core/Azure.Core/src/RequestContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Threading.Tasks;
using System.Threading;
using System.Buffers;
using System.Collections.Generic;
christothes marked this conversation as resolved.
Show resolved Hide resolved

namespace Azure.Core
{
Expand Down Expand Up @@ -105,7 +106,8 @@ public override void WriteTo(Stream stream, CancellationToken cancellationToken)
{
cancellationToken.ThrowIfCancellationRequested();
var read = _stream.Read(buffer, 0, buffer.Length);
if (read == 0) { break; }
if (read == 0)
christothes marked this conversation as resolved.
Show resolved Hide resolved
{ break; }
cancellationToken.ThrowIfCancellationRequested();
stream.Write(buffer, 0, read);
}
Expand Down
Loading