Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing bug in EventHubs samples #17075

Closed
wants to merge 3 commits into from
Closed

Fix publishing bug in EventHubs samples #17075

wants to merge 3 commits into from

Conversation

mikeharder
Copy link
Member

  • Events are never published since sample calls return instead of break

@mikeharder mikeharder requested a review from jsquire November 19, 2020 06:40
@ghost ghost added the Event Hubs label Nov 19, 2020
jsquire
jsquire reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this, Mike. The change looks good, but we'll need to shift it to the source of the snippet so that it doesn't get lost. If you'd prefer not to do the legwork, let me know and I'm happy to take ownership.

sdk/eventhub/Azure.Messaging.EventHubs.Processor/samples/Sample01_HelloWorld.md
@@ -39,7 +39,7 @@ try
// decision would have to be made as to whether the event should
// be dropped or published on its own.

return;
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.... thank you! This code gets generated from a snippet and this change will be lost. Do you mind adjusting line 97 here and line 107 here? I appear to have the same bug.

@mikeharder mikeharder changed the title Fix publishing bug in EventHubs sample Fix publishing bug in EventHubs samples Nov 19, 2020
@mikeharder
Copy link
Member Author

Fixed in #17085

@mikeharder mikeharder closed this Nov 19, 2020
@mikeharder mikeharder deleted the event-hubs-sample branch November 19, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire left review comments

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @jsquire