Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing bug in EventHubs samples #17075

Closed
wants to merge 3 commits into from
Closed

Fix publishing bug in EventHubs samples #17075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8552e33
Fix publishing bug in EventHubs sample
mikeharder Nov 19, 2020
8910bf6
Fix publishing bug in EventHubs samples
mikeharder Nov 19, 2020
4042e45
Update generated code
mikeharder Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs.Processor/samples/Sample01_HelloWorld.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ try
// decision would have to be made as to whether the event should
// be dropped or published on its own.

return;
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.... thank you! This code gets generated from a snippet and this change will be lost. Do you mind adjusting line 97 here and line 107 here? I appear to have the same bug.

}
}

Expand Down
2 changes: 1 addition & 1 deletion ...enthub/Azure.Messaging.EventHubs.Processor/tests/Snippets/Sample01_HelloWorldLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public async Task PublishEvents()
// decision would have to be made as to whether the event should
// be dropped or published on its own.

return;
break;
}
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs/samples/Sample01_HelloWorld.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ try
// decision would have to be made as to whether the event should
// be dropped or published on its own.

return;
break;
}
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs/tests/Snippets/Sample01_HelloWorldLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public async Task PublishEvents()
// decision would have to be made as to whether the event should
// be dropped or published on its own.

return;
break;
}
}

Expand Down