Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for installPatches API #17226

Conversation

rane-rajasi
Copy link

@rane-rajasi rane-rajasi commented Nov 30, 2020

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@rane-rajasi rane-rajasi reopened this Nov 30, 2020
global.json Outdated Show resolved Hide resolved
@nisha-bhatia
Copy link
Member

@rane-rajasi should there still be a "do not merge" label on this pr? If this pr is being used for testing, please convert to a draft pr. Thanks.

@nisha-bhatia
Copy link
Member

@rane-rajasi Any updates on this PR? Thank you.

@nisha-bhatia
Copy link
Member

@rane-rajasi If there are no updates to this PR by this Friday, this PR will be closed. Thank you

@rane-rajasi
Copy link
Author

Please follow up with Adam Sandor for updates regarding this PR. Since it is in compute-2020-12, Adam will have more details on the PR

@nisha-bhatia
Copy link
Member

@Sandido this PR currently has merge conflicts. Could these please be resolved? Thanks

@allenjzhang allenjzhang self-assigned this Jan 21, 2021
@Sandido
Copy link
Member

Sandido commented Jan 21, 2021

closing for now

@Sandido Sandido closed this Jan 21, 2021
@Sandido Sandido reopened this Jan 21, 2021
@nisha-bhatia nisha-bhatia removed their assignment Jan 21, 2021
@rane-rajasi rane-rajasi reopened this Feb 8, 2021
@rane-rajasi
Copy link
Author

@Sandido Updated the PR with latest from compute-2020-12. Please review

This was referenced Feb 8, 2021
@markcowl markcowl closed this Feb 18, 2021
@markcowl markcowl deleted the branch Azure:compute-2020-12 February 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants