Add support for recorded tests. #18836
Conversation
azabbasi
requested review from
AlexGhiondea,
danieljurek and
mitchdenny
as code owners
| @@ -4,3 +4,4 @@ | |||
| using System.Runtime.CompilerServices; | |||
|
|
|||
| [assembly: InternalsVisibleTo("Azure.Iot.ModelsRepository.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] | |||
| [assembly: Azure.Core.AzureResourceProviderNamespace("Azure.Iot.ModelsRepository")] | |||
There was a problem hiding this comment.
Since there is no resource provider for the SDK, I used the same namespace as the project. I will verify that with SDK team
|
|
||
| namespace Azure.Iot.ModelsRepository.Tests | ||
| { | ||
| public class ModelRepoRecordedTestBase : RecordedTestBase<ModelRepoTestEnvironment> |
There was a problem hiding this comment.
There is only one set of tests that need recording and they are in ResolverIntegrationTests
|
|
||
| public static string TestDirectoryPath => Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location); | ||
|
|
||
| public static string TestLocalModelRepository => Path.Combine(TestDirectoryPath, "TestModelRepo"); | ||
|
|
||
| public static string TestRemoteModelRepository => Environment.GetEnvironmentVariable("PNP_TEST_REMOTE_REPO") ?? s_fallbackTestRemoteRepo; | ||
| public static string TestRemoteModelRepository => Environment.GetEnvironmentVariable("PNP_TEST_REMOTE_REPO") ?? FallbackTestRemoteRepo; |
There was a problem hiding this comment.
Since there is no resources to be deployed, I would like to change this value to be straight up the FallbackTestRemoteRepo, unless anyone sees value in having a repo stored in an environment variable.
There was a problem hiding this comment.
FallbackTestRemoteRepo is actually the default repo so we can even get rid of that.
There was a problem hiding this comment.
The historical purpose of the env var was to support running remote tests on non prod model repos, for example testing against a forked repo or a test endpoint https://devicemodeltest.azureedge.net/
sdk/modelsrepository/Azure.Iot.ModelsRepository/tests/ResolveIntegrationTests.cs
Outdated
Show resolved
Hide resolved
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
sdk/modelsrepository/Azure.Iot.ModelsRepository/tests/ModelRepoRecordedTestBase.cs
Outdated
Show resolved
Hide resolved
* Initial Commit - Bring ModelRepository Project to the mono repo (#18706) * Use resx file and update formattings. * Add client diagnostics - Add sync APIs to RemoteFetcher and LocalFetcher (#18807) * Add async methods to the ResolverClient (#18814) * Add support for recorded tests. (#18836) * Add support for recorded tests. * Make strings constants * Update file names to include plural models * Refactor RepositoryHandler and ResolverClient (#18857) * Refactor ModelQuery (#18843) * Refactor ModelQuery. * Combine constant files. * Rename Client to ModelsRepoClient (#18862) * Remove ResolverException in favor of RequestFailedException (#18874) * Remove ResolverException in favor of RequestFailedException. Adds more docstrings. * Rename Repo to Repository and minor changes / Import samples project (#18986) * Format changes/Remove resx file. * Add first draft of readme. Add comment for dtmi validation. (#18987) * Add comment for dtmi validation. * Fix links. * Add diagnostic event info. * Source link specifically pointing to 'src' folder. * Use fluent assertion * Use playback as default * fix Links and root service directory casing Co-authored-by: Paymaun <Paymaunh@microsoft.com>
No description provided.