Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Repo to Repository and minor changes / Import samples project #18986

Merged
merged 7 commits into from
Feb 24, 2021

Conversation

azabbasi
Copy link
Contributor

@azabbasi azabbasi commented Feb 24, 2021

In this PR :

  • Rename ModelsRepoClient to ModelsRepositoryClient (along with all related file and class names like options and test base classes that borrowed the name of the client)
  • Remove getter and auto property for ClientOptions as per Krzysztof's comment
  • Bring over Samples project and clean out the parser related pieces
  • Rework Exception handling in RemoteModelFetcher to include status code and other exception fields from the originally thrown exception.

One outstanding question is regarding the LocalModelFetcher exception handling. When LocalModelFetcher throws a RequestFailedException there is no outgoing HTTP call and as a result there is no status code attached to the RequestFailedException which in my opinion is the correct behavior as there is no HTTP stack involved. on the other hand, the consumer might be relying on the status code. we have to have a brief discussion about that.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@azabbasi azabbasi changed the title Rename Repo to Repository and minor changes. Rename Repo to Repository and minor changes / Import samples project Feb 24, 2021
@azabbasi azabbasi merged commit f784e78 into feature/modelsRepo Feb 24, 2021
@azabbasi azabbasi deleted the azabbasi/addressComments branch February 24, 2021 19:07
azabbasi added a commit that referenced this pull request Feb 25, 2021
* Initial Commit - Bring ModelRepository Project to the mono repo (#18706)
* Use resx file and update formattings.
* Add client diagnostics - Add sync APIs to RemoteFetcher and LocalFetcher (#18807)
* Add async methods to the ResolverClient (#18814)
* Add support for recorded tests. (#18836)
* Add support for recorded tests.
* Make strings constants
* Update file names to include plural models
* Refactor RepositoryHandler and ResolverClient (#18857)
* Refactor ModelQuery (#18843)
* Refactor ModelQuery.
* Combine constant files.
* Rename Client to ModelsRepoClient (#18862)
* Remove ResolverException in favor of RequestFailedException (#18874)
* Remove ResolverException in favor of RequestFailedException. Adds more docstrings.
* Rename Repo to Repository and minor changes / Import samples project (#18986)
* Format changes/Remove resx file.
* Add first draft of readme. Add comment for dtmi validation. (#18987)
* Add comment for dtmi validation.
* Fix links.
* Add diagnostic event info.
* Source link specifically pointing to 'src' folder.
* Use fluent assertion
* Use playback as default
* fix Links and root service directory casing
Co-authored-by: Paymaun <Paymaunh@microsoft.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request May 24, 2022
Merge Cognitive Services - Language pillar version 2022-05-15-preview to main (Azure#19186)

* Updated May-1 preview to include changes from March-1 preview (Azure#18580)

* Updated May-1 preview to include changes from March-1 preview

* Fixed a missed api version update in an example file

Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>

* [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (Azure#17847)

* Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization

* Add Issue Resolution Summary

* Address comments

* address pretty chek and spell check issues

* address file name mismatch issue

* typo

* Add IRD updates

* Add IRD Schema changes

* Response Files content update

* Address feedback

* Address PR comments

* Address comments

* Add the May API version

* Address comments

* Remove 04-01 and address comments

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Address feedback V-1.

* Address all comments expect model + enum descriptions

* Fx validations

* Missed files

* Conversation Item modality issue

* Update PII Task

* Address Spec validation errors

* Updates

* Fix PII issues

* Add readonly

* Update schema

* Updates

* Bring back Text Conversation Item

* Update example

* Space in Json

* Address comments

* Address one more comments

* Fix model validation

* Fix

* Update spec

* Address comments

* Move requestStatistics, prebuiltResult, error and warnings object to common

* Address circular dependency

Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Rename version from 2022-05-01-preview to 2022-05-15-preview (Azure#18737)

* Update CLU swagger (Azure#18739)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Use azure-sdk-for-net-track2 for validation (Azure#18755)

* Bidishac/update field description (#18787)

* Update the messaging on the parameter type

* Update the documentation of the redactionSource field

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

Co-authored-by: Chong Tang <ct4ew@virginia.edu>
Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Unify the runtime and authoring APIs (Azure#18837)

* unifying single classification and multi classification to return array of class (Azure#18902)

* Renaming in 2022-05-15-preview (Azure#18929)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Rename 'summary' in summaryAspects to 'issue' (Azure#18941)

* Rename 'summary' in summaryAspects to 'issue'

* Merge issues

* Update model version value

* Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (Azure#18943)

* Merge 2022-05-01-GA files changes into 2022-05-15-preview branch

* Address Avocado issues and revert case update for Luis

* Add the missing error codes

* Fix avocado

* Avocado fix

* Add api-version parameter to cancel job endpoint (Azure#18986)

* Add api-version parameter to cancel job endpoint

* Fix taskState and jobState

* Revert "Fix taskState and jobState"

This reverts commit 148dd2183249add89a090721db36a14c2b15d9bd.

* Update LUIS to Luis in model names (Azure#19012)

* Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (Azure#19031)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Added fhir feature updates to 2022-05-15-preview (Azure#19092)

Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>

* Add cancel endpoint for conversations (Azure#19025)

* Add cancel endpoint for conversations

* Update examples path

* Make the input for transcriptConversationItem optional

* Bidishac/update enum name (Azure#19149)

* Update name to CreditCard

* Update entity categories for PII for build

* Keep SSN

* Revert "Keep SSN"

This reverts commit 77a92119ebd71cf5d5c7f201d402514756289ec2.

* Update readme.md

Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com>
Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>
Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com>
Co-authored-by: Chong Tang <ct4ew@virginia.edu>
Co-authored-by: Chong Tang <chot@microsoft.com>
Co-authored-by: Mohamed Abbas <moaba@microsoft.com>
Co-authored-by: Nourhan <92883092+nourhaanfarid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants