Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to changelog for Microsoft.Azure.ServiceBus SDK version 5.1.2 #18994

Merged
merged 9 commits into from
Feb 24, 2021
Merged

Add to changelog for Microsoft.Azure.ServiceBus SDK version 5.1.2 #18994

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ece7b5
add changelog for a new nuget minor version bump
DorothySun216 Nov 20, 2020
00487b7
Revert "add changelog for a new nuget minor version bump"
DorothySun216 Nov 20, 2020
f730445
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
DorothySun216 Jan 12, 2021
43f8ab6
add change log for amqp lib update
DorothySun216 Jan 12, 2021
d1fc477
sync with upstream head
DorothySun216 Feb 23, 2021
4c80363
add readme for 5.1.2
DorothySun216 Feb 24, 2021
370715f
update amqp dep
DorothySun216 Feb 24, 2021
63a25f0
remove deplicate amqp dependency
DorothySun216 Feb 24, 2021
5b3d8f2
Revert "remove deplicate amqp dependency"
DorothySun216 Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
Dependency versions for Track 1 libraries.
-->
<ItemGroup Condition="'$(IsClientLibrary)' != 'true'">
<PackageReference Update="Microsoft.Azure.Amqp" Version="2.4.9" />
<PackageReference Update="Microsoft.Azure.Batch" Version="11.0.0" />
<PackageReference Update="Microsoft.Azure.Devices.Client" Version="1.23.2" />
<PackageReference Update="Microsoft.Azure.Devices" Version="1.19.0" />
Expand Down Expand Up @@ -83,7 +82,7 @@
<PackageReference Update="Azure.Storage.Blobs" Version="12.8.0" />

<!-- Other approved packages -->
<PackageReference Update="Microsoft.Azure.Amqp" Version="2.4.9" />
<PackageReference Update="Microsoft.Azure.Amqp" Version="2.4.11" />
<PackageReference Update="Microsoft.Identity.Client" Version="4.23.0" />
<PackageReference Update="Microsoft.Identity.Client.Extensions.Msal" Version="2.16.6" />
<!-- TODO: Make sure this package is arch-board approved -->
Expand Down
6 changes: 6 additions & 0 deletions sdk/servicebus/Microsoft.Azure.ServiceBus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

## 5.1.0-beta.1 (Unreleased)

## 5.1.2 (2021-02-24)
- Update dependency of Microsoft.Azure.Amqp to version 2.4.11 to take in the fix: In auto-flow mode, do not issue more credits when the receiver link is closing.
This solves the bug when prefetch mode is enabled, unexpected number of messages will not be released properly so their delivery count will increase.
- Remove unnecessary Manage claim from sender and receiver. This will fix the scenario where customized TokenProvider is not giving Manage claims [PR 18740](https://github.com/Azure/azure-sdk-for-net/pull/18740)
- Fix Unregister and Re-Register a Message/Session Handler results in System.ObjectDisposedException [PR 18899](https://github.com/Azure/azure-sdk-for-net/pull/18899)

## 5.1.1 (2021-01-12)
- Update dependency of Microsoft.Azure.Amqp to version 2.4.9

Expand Down
2 changes: 1 addition & 1 deletion sdk/servicebus/Microsoft.Azure.ServiceBus/src/Message.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ public long EnqueuedSequenceNumber
internal set => this.enqueuedSequenceNumber = value;
}

/// <summary>Gets or sets the date and time of the sent time in UTC.</summary>
/// <summary>Gets the date and time of the sent time in UTC.</summary>
/// <value>The enqueue time in UTC. </value>
/// <remarks>
/// The UTC instant at which the message has been accepted and stored in the entity.
Expand Down
3 changes: 1 addition & 2 deletions sdk/servicebus/Microsoft.Azure.ServiceBus/src/Microsoft.Azure.ServiceBus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
<PropertyGroup>
<AssemblyTitle>Azure ServiceBus SDK</AssemblyTitle>
<Description>This is the next generation Azure Service Bus .NET Standard client library that focuses on queues &amp; topics. For more information about Service Bus, see https://azure.microsoft.com/en-us/services/service-bus/</Description>
<Version>5.2.0-beta.1</Version>
<ApiCompatVersion>5.1.1</ApiCompatVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we running API Compat on T1 libraries? If so, this should stay.

//cc: @JoshLove-msft, do you know for sure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but this would get added automatically after release to reference the new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ideally, we wouldn't touch the ApiCompatVersion as it should be handled automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the ApiCompatVersion deletion and then we should be good to merge.

Copy link
Member

@JoshLove-msft JoshLove-msft Feb 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @weshaggard do you know if ApiCompat is run for T1 libraries? For Service Bus T1 in particular, they use a test to detect API changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18995

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ApiCompat should be run on any library that is participating in our engineering system.

<Version>5.1.2</Version>
<PackageTags>Microsoft;Azure;Service Bus;ServiceBus;.NET;AMQP;IoT;Queue;Topic</PackageTags>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<NoWarn>$(NoWarn);CS1591;CS1573;NU5125</NoWarn>
Expand Down