-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACR] Add model factory for mocking #21191
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
May 20, 2021 20:58
This should get auto-generated when the current Autorest PR merges. #21225 |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 14, 2023
[Hub Generated] Review request for Microsoft.Media/Streaming to add version stable/2022-11-01 (Azure#21191) * Adds base for updating Microsoft.Media/Streaming from version stable/2022-08-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * add changes to 2022-11-01 * fix for linter and avocado * fix format * address all comments * remove extra white space * fix format * fix model validation * fix all warnings * fix for comments * fix lint * add properties to model and fix comments * change api method to POST and update example files * fix operationId * fix operationId again * fix healthDescription property * fix example * fix descriptions for status properties * add description of stream event properties * add descriptions for stream event properties * fix validation * fix prettier * mark time string as date-time format * add timedMetadataEndpoints property to live event properties * fix validation * fix description and example * annotate date-time format for one property * update example * add two additional properties to getStatus response * fix example * fix merge * fix spell check * fix readme * add API readiness tests for the new vesrion * fix API readiness test --------- Co-authored-by: Stephanie Han <minhan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Azure SDK .NET Guidelines on mocking, provide a
ContainerRegistryModelFactory
class for creating mock instances of model types.Fixes #21144