Update AutoRest C# version #21225

azure-sdk · 2021-05-20T14:43:40Z

Update AutoRest C# version to 3.0.0-beta.20210520.2

chamons · 2021-05-20T14:53:20Z

This requires manual changes for the security attribute change.

check-enforcer · 2021-05-20T15:03:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

chamons · 2021-05-20T16:04:53Z

Blew away my work, again :(

chamons · 2021-05-20T17:12:29Z

Failing with:

  Failed ObserveExistingAssetConversion [15 s]
  Error Message:
   System.IO.IOException : No space left on device

JoshLove-msft

Event Grid changes look good.

heaths

The factory isn't really needed in either KV project. See comments for details.

heaths · 2021-05-20T20:00:25Z

sdk/keyvault/samples/sharelink/Generated/AzureSecurityKeyVaultStorageModelFactory.cs

@@ -0,0 +1,169 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.


This is a sample and doesn't need this. I'd rather not have to maintain it or complicate the sample with unnecessary code.

If this can't be elided, can you at least use the CodeModelAttribute to make it internal. I'd rather not have it in the sample, but not exposing it is next best.

heaths · 2021-05-20T20:03:52Z

...ity.KeyVault.Administration/src/Generated/AzureSecurityKeyVaultAdministrationModelFactory.cs

@@ -0,0 +1,53 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.


This doesn't add any value since all classes are constructable with public members. Can we suppress this for now? I wouldn't want to call the class name this anyway, as it doesn't follow our existing naming convention we used in other packages.

For example, can we use existing model renaming functionality to not only rename this but also hide it?

I'll make it internal for now. Do you need an ability to be able to remove it completely?

Don't need it, but definitely need the ability to rename it. That is not the naming convention we have used throughout all the languages SDKs for KV.

Given what you told Mariana, could you rename this to just AdministrationModelFactory. That aligns with our other model factories in our other KV packages.

chamons · 2021-05-20T20:06:29Z

I believe there is a key @AlexanderSher can add to your project to disable it.

pakrym · 2021-05-20T20:12:13Z

sdk/storage/Azure.Storage.Queues/src/Generated/AzureQueueStorageModelFactory.cs

+namespace Azure.Storage.Queues
+{
+    /// <summary> Model factory for AzureQueueStorage read-only models. </summary>
+    public static partial class AzureQueueStorageModelFactory


Need to be reconciled with https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/storage/Azure.Storage.Queues/src/Models/QueuesModelFactory.cs

Could the generator define a new attribute like CodeModelAttribute where, if provided, you use that name? That would also help resolve one of my comments.

AlexanderSher · 2021-05-20T20:20:25Z

I have removed flag in the last commit, but I can bring it back. However, adding an ability to remove specific types from codegen sounds like a better, though more complicated approach.

maririos · 2021-05-20T20:40:09Z

sdk/formrecognizer/Azure.AI.FormRecognizer/src/Generated/FormRecognizerModelFactory.cs

+using Azure.AI.FormRecognizer.Models;
+using Azure.AI.FormRecognizer.Training;
+
+namespace Azure.AI.FormRecognizer


is there a way to change the namespace? what is the repercussion for this in FR? https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/formrecognizer/Azure.AI.FormRecognizer/src/FormRecognizerModelFactory.cs#L11

Also, we are in code freeze for anything that modifies the public API for FR until we go GA next week

Yes, you can change namespace and type name similar to REST client:

[CodeGenType("GeneratedModelFactory")] partial class MyModelFactory

maririos · 2021-05-20T20:42:00Z

...nslation/Azure.AI.Translation.Document/src/Generated/BatchDocumentTranslationModelFactory.cs

+        /// <param name="documentId"> Document Id. </param>
+        /// <param name="charactersCharged"> Character charged by the API. </param>
+        /// <returns> A new <see cref="Document.DocumentStatusResult"/> instance for mocking. </returns>
+        public static DocumentStatusResult DocumentStatusResult(Uri translatedDocumentUri = default, Uri sourceDocumentUri = default, DateTimeOffset createdOn = default, DateTimeOffset lastModified = default, TranslationStatus status = default, string translateTo = default, DocumentTranslationError error = default, float progress = default, string documentId = default, long charactersCharged = default)


curious, why there are only 2 types generated here?
also, why is everything with =default?

maririos · 2021-05-20T20:43:09Z

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/TextAnalyticsModelFactory.cs

+        /// <param name="certainty"> Describes the entities certainty and polarity. </param>
+        /// <param name="association"> Describes if the entity is the subject of the text or if it describes someone else. </param>
+        /// <returns> A new <see cref="TextAnalytics.HealthcareEntityAssertion"/> instance for mocking. </returns>
+        public static HealthcareEntityAssertion HealthcareEntityAssertion(EntityConditionality? conditionality = default, EntityCertainty? certainty = default, EntityAssociation? association = default)


I feel like there are a ton of other types missing. do you know why is that? i.e. HealthcareEntity

HealthcareEntity is hand-written type, the one that is generated is HealthcareEntityInternal:

azure-sdk-for-net/sdk/textanalytics/Azure.AI.TextAnalytics/src/Internal/HealthcareEntityInternal.cs

Line 12 in 006cfd3

internal partial class HealthcareEntityInternal { }

This type is made internal, so there can be no public factory method for it.

christothes

tables looks good.

heaths · 2021-05-20T23:07:05Z

...ity.KeyVault.Administration/src/Generated/AzureSecurityKeyVaultAdministrationModelFactory.cs

+
+namespace Azure.Security.KeyVault.Administration
+{
+    /// <summary> Model factory for AzureSecurityKeyVaultAdministration read-only models. </summary>


The name in the comment doesn't make sense. I'd just elide it from generated code and leave the comment "Model factory for read-only models." The package name really doesn't add much value to the statement anyway.

annelo-msft · 2021-05-20T23:54:15Z

Fixes #21144

LarryOsterman

Attestation looks good.

Mohit-Chakraborty · 2021-05-21T17:36:14Z

sdk/search/Azure.Search.Documents/src/Generated/SearchServiceModelFactory.cs

+namespace Azure.Search.Documents
+{
+    /// <summary> Model factory for SearchService read-only models. </summary>
+    public static partial class SearchServiceModelFactory


Noob questions here -

What is this needed for?

Will I manually update this file if a change is needed (like yanking out some model type)?

These classes are only for customer tests e.g. for mocking - to create models that have members customers can't otherwise set because they are response-only, for example. See https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-mocking for more details.

Thanks Heath.

AlexanderSher · 2021-05-24T20:35:00Z

Replaced with #21301 to unblock other work in Autorest

azure-sdk requested review from aim-for-better, AlexGhiondea, chamons, chidozieononiwu, christothes, danieljurek, idear1203, mitchdenny and weshaggard as code owners May 20, 2021 14:43

azure-sdk force-pushed the auto-update-autorest branch from 51241a1 to 1ff43e0 Compare May 20, 2021 14:47

azure-sdk force-pushed the auto-update-autorest branch from 11989ee to f5778e6 Compare May 20, 2021 16:00

chamons mentioned this pull request May 20, 2021

[Infrastructure] Fix autobump tool to stop blowing away work in mid-PR Azure/autorest.csharp#1258

Closed

azure-sdk force-pushed the auto-update-autorest branch from 58d3b80 to 6438194 Compare May 20, 2021 17:12

chamons mentioned this pull request May 20, 2021

Update AutoRest C# version #21232

Merged

azure-sdk force-pushed the auto-update-autorest branch from 6438194 to 1e1db40 Compare May 20, 2021 19:26

azure-sdk requested review from abhipsaMisra, ahamad-MS, amishra-dev, amnguye, annelo-msft, arv100kri, azabbasi, barustum, bikamani, bleroy and brjohnstmsft as code owners May 20, 2021 19:26

azure-sdk requested review from schaabs, seanmcc-msft, tg-msft, timtay-microsoft, vinagesh, yeskarthik and a team as code owners May 20, 2021 19:26

JoshLove-msft approved these changes May 20, 2021

View reviewed changes

heaths requested changes May 20, 2021

View reviewed changes

pakrym reviewed May 20, 2021

View reviewed changes

azure-sdk force-pushed the auto-update-autorest branch from 1e1db40 to d3a59b9 Compare May 20, 2021 20:13

maririos reviewed May 20, 2021

View reviewed changes

christothes approved these changes May 20, 2021

View reviewed changes

christothes mentioned this pull request May 20, 2021

[ACR] Add model factory for mocking #21191

Closed

azure-sdk force-pushed the auto-update-autorest branch from d3a59b9 to 8f88549 Compare May 20, 2021 22:51

heaths reviewed May 20, 2021

View reviewed changes

annelo-msft mentioned this pull request May 20, 2021

[ACR] Add ContainerRegistryModelFactory for Mocking #21144

Closed

LarryOsterman approved these changes May 21, 2021

View reviewed changes

azure-sdk force-pushed the auto-update-autorest branch 2 times, most recently from aa80d4a to 1724e32 Compare May 21, 2021 17:24

Mohit-Chakraborty reviewed May 21, 2021

View reviewed changes

Update AutoRest C# version to 3.0.0-beta.20210524.1

5187587

azure-sdk force-pushed the auto-update-autorest branch from 1724e32 to 5187587 Compare May 24, 2021 15:36

AlexanderSher closed this May 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update AutoRest C# version #21225

Update AutoRest C# version #21225

azure-sdk commented May 20, 2021

chamons commented May 20, 2021

check-enforcer bot commented May 20, 2021

chamons commented May 20, 2021

chamons commented May 20, 2021

JoshLove-msft left a comment

heaths left a comment

heaths May 20, 2021

heaths May 20, 2021

heaths May 20, 2021

AlexanderSher May 20, 2021

heaths May 20, 2021

heaths May 20, 2021

chamons commented May 20, 2021

pakrym May 20, 2021

heaths May 20, 2021

AlexanderSher commented May 20, 2021

maririos May 20, 2021 •

edited

Loading

AlexanderSher May 20, 2021

maririos May 20, 2021

maririos May 20, 2021

AlexanderSher May 20, 2021

christothes left a comment

heaths May 20, 2021

annelo-msft commented May 20, 2021

LarryOsterman left a comment

Mohit-Chakraborty May 21, 2021

heaths May 21, 2021 •

edited

Loading

Mohit-Chakraborty May 21, 2021

AlexanderSher commented May 24, 2021

		@@ -0,0 +1,169 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

		@@ -0,0 +1,53 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

Update AutoRest C# version #21225

Update AutoRest C# version #21225

Conversation

azure-sdk commented May 20, 2021

chamons commented May 20, 2021

check-enforcer bot commented May 20, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

chamons commented May 20, 2021

chamons commented May 20, 2021

JoshLove-msft left a comment

Choose a reason for hiding this comment

heaths left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chamons commented May 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexanderSher commented May 20, 2021

maririos May 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christothes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annelo-msft commented May 20, 2021

LarryOsterman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heaths May 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexanderSher commented May 24, 2021

maririos May 20, 2021 •

edited

Loading

heaths May 21, 2021 •

edited

Loading