Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsAdvisor] Added options for configuration listing methods #21448

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

kinelski
Copy link
Member

@kinelski kinelski commented May 29, 2021

Part of #21177.

Originally, the service returned a list for methods GetDetectionConfigurations and GetAlertConfigurations, and we were artificially wrapping them in a pageable to expose to users.

Now these methods return true pageables, and have support for the Skip and MaxPageSize paging properties. Put them in new Options types and updated the methods.

Tests haven't been added yet. They will be added as part of #20621.

@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels May 29, 2021
@kinelski kinelski requested a review from maririos May 29, 2021 01:37
@kinelski kinelski self-assigned this May 29, 2021
@kinelski kinelski merged commit e96dd6d into Azure:master Jun 1, 2021
@kinelski kinelski deleted the ma-options branch June 1, 2021 18:46
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 24, 2022
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 (Azure#21448)

* Adds base for updating Microsoft.RecoveryServices from version preview/2022-09-30-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Minor markdown linting issue

* Modified the formatting

* used common parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants