Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Update code with latest swagger changes #21177

Closed
10 tasks done
kinelski opened this issue May 19, 2021 · 1 comment
Closed
10 tasks done

[MetricsAdvisor] Update code with latest swagger changes #21177

kinelski opened this issue May 19, 2021 · 1 comment
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] June

Comments

@kinelski
Copy link
Member

kinelski commented May 19, 2021 •
edited
Loading

  • Regenerate code from latest swagger.
  • Fix Update methods:
    • UpdateDataFeed
    • UpdateDetectionConfiguration
    • UpdateAlertConfiguration
    • UpdateHook
  • Update listing detection and alert configs methods since they're now real pageables (include "skip" and "maxPageSize" properties).
  • Add DataFeedId property to DataPointAnomaly and AnomalyIncident.
  • Update source and tests to reflect sensitive data not being returned anymore.
  • Remove "PerSecond" granularity value as it won't be supported by the service anymore.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Metrics Advisor labels May 19, 2021
@kinelski kinelski self-assigned this May 19, 2021
@kinelski kinelski added this to the [2021] June milestone May 19, 2021
@kinelski kinelski mentioned this issue May 19, 2021
Merged
This was referenced May 29, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@kinelski
Copy link
Member Author

kinelski commented Jun 4, 2021

All issues addressed in multiple PRs.

@kinelski kinelski closed this as completed Jun 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] June
Development

No branches or pull requests
1 participant
@kinelski