[MetricsAdvisor] Fixed UpdateHook methods #21559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
kinelski
commented
Jun 3, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs
Show resolved
Hide resolved
kinelski
commented
Jun 3, 2021
...metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/CodeGenInternal/EmailHookParameterPatch.cs
Show resolved
Hide resolved
kinelski
commented
Jun 3, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/NotificationHook/NotificationHook.cs
Show resolved
Hide resolved
kinelski
commented
Jun 3, 2021
...zure.AI.MetricsAdvisor/tests/MetricsAdvisorAdministrationClient/NotificationHookLiveTests.cs
Show resolved
Hide resolved
maririos
reviewed
Jun 4, 2021
...zure.AI.MetricsAdvisor/tests/MetricsAdvisorAdministrationClient/NotificationHookLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/Samples/Sample04_HookCrudOperations.cs
Show resolved
Hide resolved
maririos
approved these changes
Jun 4, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Nov 24, 2022
Review request for Microsoft.ContainerService to add version 2022-10-02-preview (Azure#21439) * Adds base for updating Microsoft.ContainerService from version preview/2022-09-02-preview to version 2022-10-02-preview * Updates readme * Updates API version in new specs and examples * Pmiller/nodeosupgradechannel (Azure#21326) * missed working comment * matthew comments * unpatched is a word * Add MaintenanceWindow into MaintenanceConfigurationProperties (Azure#21337) * Add MaintenanceWindow into MaintenanceConfigurationProperties * Fx PrettierCheck * Fix ARM ID format for samples (Azure#21402) * Fix Swagger Model Validation for the 2022-10-02-preview dev branch of container service (Azure#21373) * fix API version * fix INVALID_FORMAT byte * fix INVALID_FORMAT arm-id * fix missing resource id * fix LRO_RESPONSE_HEADER * Update readmes for the 2022-10-02-preview dev branch of container service (Azure#21366) * update readmes * remove fleets * Updating abort apis response to make it long running (Azure#21362) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header Co-authored-by: InduSridhar <indusridhar@microsoft.com> * fix 202 location header * fix ProvisioningState validation * add x-ms-long-running-operation-options * fix ResourceNameRestriction * Fix abort location url in example (Azure#21446) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples Co-authored-by: InduSridhar <indusridhar@microsoft.com> * Abort api response fix (Azure#21559) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples * Fixing headers and body for abort response * Linter fix * Lint fix * Updating managedclusters.json responses Co-authored-by: InduSridhar <indusridhar@microsoft.com> * Node os upgrade desc fix (Azure#21636) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples * Fixing headers and body for abort response * Linter fix * Lint fix * Updating managedclusters.json responses * Minor edit to node os upgrade description based on ARM review Co-authored-by: InduSridhar <indusridhar@microsoft.com> Co-authored-by: Paul Miller <pmiller@microsoft.com> Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com> Co-authored-by: InduSridhar <indusridhar@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21177