Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace following the Comment symbol #21636

Closed

Conversation

paul-cheung
Copy link
Contributor

@paul-cheung paul-cheung commented Jun 6, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration Search Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jun 6, 2021
@ghost
Copy link

ghost commented Jun 6, 2021

Thank you for your contribution @paul-cheung! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Jun 6, 2021
* Batch receive fixes

* Use AwaitWithCancellation

* volatile

* Remove unnecessary catch

* Fix tests

* Fix flaky tests

* Fix test
@Mohit-Chakraborty
Copy link
Contributor

Mohit-Chakraborty commented Jun 7, 2021

I think you need to rebase against the tip of 'master' to fix the build errors.
Edit: Actually, error in the storage/ area is a legitimate issue. I have a PR out to fix it - #21641

Mohit-Chakraborty and others added 3 commits June 6, 2021 20:44
* Batch receive fixes

* Use AwaitWithCancellation

* volatile

* Remove unnecessary catch

* Fix tests

* Fix flaky tests

* Fix test
@paul-cheung
Copy link
Contributor Author

I think you need to rebase against the tip of 'master' to fix the build errors.
Edit: Actually, error in the storage/ area is a legitimate issue. I have a PR out to fix it - #21641

rebased against the tip of upstream master

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your rebase introduced additional changes; I'm seeing Service Bus files changed that should not be part of this PR. Please revert or rebase (not merge) to master.

@paul-cheung
Copy link
Contributor Author

paul-cheung commented Jun 7, 2021

It looks like your rebase introduced additional changes; I'm seeing Service Bus files changed that should not be part of this PR. Please revert or rebase (not merge) to master.

I have raised another one for this part of change. 21649

@paul-cheung paul-cheung closed this Jun 7, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 24, 2022
Review request for Microsoft.ContainerService to add version 2022-10-02-preview (Azure#21439)

* Adds base for updating Microsoft.ContainerService from version preview/2022-09-02-preview to version 2022-10-02-preview

* Updates readme

* Updates API version in new specs and examples

* Pmiller/nodeosupgradechannel (Azure#21326)

* missed working comment

* matthew comments

* unpatched is a word

* Add MaintenanceWindow into MaintenanceConfigurationProperties (Azure#21337)

* Add MaintenanceWindow into MaintenanceConfigurationProperties

* Fx PrettierCheck

* Fix ARM ID format for samples (Azure#21402)

* Fix Swagger Model Validation for the 2022-10-02-preview dev branch of container service (Azure#21373)

* fix API version

* fix INVALID_FORMAT byte

* fix INVALID_FORMAT arm-id

* fix missing resource id

* fix LRO_RESPONSE_HEADER

* Update readmes for the 2022-10-02-preview dev branch of container service (Azure#21366)

* update readmes

* remove fleets

* Updating abort apis response to make it long running  (Azure#21362)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* fix 202 location header

* fix ProvisioningState validation

* add x-ms-long-running-operation-options

* fix ResourceNameRestriction

* Fix abort location url in example (Azure#21446)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* Abort api response fix (Azure#21559)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* Node os upgrade desc fix (Azure#21636)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

* Minor edit to node os upgrade description based on ARM review

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

Co-authored-by: Paul Miller <pmiller@microsoft.com>
Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com>
Co-authored-by: InduSridhar <indusridhar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Search Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants