-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetricsAdvisor] Regenerate code from latest swagger #21495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also remove one of our swagger transforms.
Do you mean the credential one?
Not related to your PR:
- With the pagination work you did in a previous PR, do you still need the pagination transforms?
- Any change the service can add the required properties to their swagger instead of having so many transofrms?
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
Show resolved
Hide resolved
Correct. We removed the credential transform.
The pagination work I did is not related to the transforms we have in the swagger. That was due to a service-side change.
Some of them may already be fixed on the swagger-side, but I need to double check. I will bring the discussion up with Johan, but I wouldn't say this is high priority right now. The service is a bit busy with GA, and changing a property from non-required => required in the swagger would not be a breaking change, so we can always fix it later if we can convince them. |
Part of #21177.
A bunch of internal renames and internal code changes since some properties are not marked as required anymore. We also removed the enum value
DataFeedGranularityType.PerSecond
because the service does not support it anymore.We could also remove one of our swagger transforms.