-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synapse] - Enhance SparkBatchOperation polling logic to support both job submission and job execution scenarios and fix SparkSessionOperation and SparkStatementOperation #23706
Conversation
sdk/synapse/Azure.Analytics.Synapse.Spark/api/Azure.Analytics.Synapse.Spark.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/synapse/Azure.Analytics.Synapse.Spark/src/Customization/SparkBatchOperation.cs
Outdated
Show resolved
Hide resolved
bf8933c
to
25c5298
Compare
fce0b16
to
2dbf8fb
Compare
sdk/synapse/Azure.Analytics.Synapse.Spark/src/Customization/SparkBatchOperation.cs
Outdated
Show resolved
Hide resolved
sdk/synapse/Azure.Analytics.Synapse.Spark/src/Customization/SparkBatchOperation.cs
Outdated
Show resolved
Hide resolved
sdk/synapse/Azure.Analytics.Synapse.Spark/tests/SparkBatchClientLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/synapse/Azure.Analytics.Synapse.Spark/tests/SparkBatchClientLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/synapse/Azure.Analytics.Synapse.Spark/api/Azure.Analytics.Synapse.Spark.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
b15794f
to
e162316
Compare
8a130b3
to
94447a4
Compare
API changes have been detected in this PR. You can review API changes here |
API changes have been detected in this PR. You can review API changes here |
Release apimanagement 2022 09 01 preview (Azure#22978) * Adds base for updating Microsoft.ApiManagement from version stable/2022-08-01 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Add circuit breaker to the backend contract (Azure#21320) (Azure#23359) * add circuit breaker to the backend contract * resolve validation errors * Revert "resolve validation errors" and last push This reverts commit c55768584cffca0d61fed6d731fd85b0a0e8ede6. * resolve validation errors * run prettier * stv2.1 (Azure#23326) * added Workspaces feature-related endpoints and contracts (Azure#23330) * added Workspaces feature-related endpoints and contracts * cleanup * prettier * + examples * - redundant examples * link contracts for PUT * typo * Location header added to async operations --------- Co-authored-by: promoisha <glfeokti@microsoft.com> * New ApiVersion 2022-09-01-preview : Fix Linter errors (Azure#23706) * x-ms-pageable extension for all list calls on policy * x-ms-secret to secret values * location header and invalid produces * New Api-Version 2022-09-01-preview: Linter Errors (Azure#23739) * boolean to x-ms-enum * add location header to 202 response * Location header to all 202 operations --------- Co-authored-by: Mahsa Sadi <mahsa.sadi@utoronto.ca> Co-authored-by: promoisha <feoktistovgg@gmail.com> Co-authored-by: promoisha <glfeokti@microsoft.com>
All SDK Contribution checklist:
Fix the issue brought in the PR: #17920 .
Spark job has two phases: job submission and job execution. If we want to return when job submission is over, both "starting" and "running" should be considered as terminating states. If we want to return when job execution is over, we should not return when job state is "starting" or "running".
The PR aims to fixing the polling logic by supporting both scenarios of job submission and job execution. It adds a new
UpdateStatus
method with a parameter to determine whether to wait for completion of job execution.This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.