Prevent ObjectDisposedException if Key Vault config provider disposed twice #24769

martincostello · 2021-10-17T17:44:32Z

Prevent ObjectDisposeException if AzureKeyVaultConfigurationProvider is disposed of more than once.

See dotnet/aspnetcore#37631.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Prevent ObjectDisposeException if AzureKeyVaultConfigurationProvider is disposed of more than once. See dotnet/aspnetcore#37631.

ghost · 2021-10-17T17:44:39Z

Thank you for your contribution @martincostello! We will review the pull request and get back to you soon.

pakrym · 2021-10-25T16:10:19Z

Thank you @martincostello !

commit d636e0663f8bc6344fc74dfbbb65e09685e6615f Author: hivyas <61890270+hivyas@users.noreply.github.com> Date: Mon Oct 25 15:55:50 2021 -0700 [VideoAnalyzer] Updating version number to correct version (#24903) * generated new models and updated sample * updated sample, readme, and changelog * addressing pr comments and exported api * renaming variable to address pr comment * removing en-us from link * changes based off pr comments * updating version number * updating version in readme * adding 1.1 version back to changelog * changing order of versions in ReadMe: * updating version number in csproj * removing 1.1 changelog entry commit 6cc612a7232655cbf65c51cdd5e6f943f795fba2 Author: Mariana Rios Flores <mariari@microsoft.com> Date: Mon Oct 25 14:58:54 2021 -0700 [DT] Update error code in test (#24758) commit 9f68a7e2a49e6259f203249945e8a543cee55c5d Author: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Date: Mon Oct 25 10:52:52 2021 -0700 Fixing docs to correct append blob to page blobs in page blob docs (#24902) commit f6319e4b06a8dbc8bd6913b02c0f19f6dc09c15c Author: Martin Costello <martin@martincostello.com> Date: Mon Oct 25 17:10:23 2021 +0100 Prevent ObjectDisposedException if Key Vault config provider disposed twice (#24769) commit cbef31d9894a62cddb2140b05fa3f64c03abf30f Author: Martin Barnas <martinbarnas@microsoft.com> Date: Mon Oct 25 09:16:28 2021 +0200 fix value for enum ServiceVersion (#24893) commit 0569ba1257357dada854b024698807172167d72c Author: giakas <giakas@microsoft.com> Date: Sun Oct 24 19:20:35 2021 -0700 Regenerate AVA managmenet SDK with small swagger changes (#24888) commit 52d7c4749a99a88cef923570adf835e9d0aea7e2 Author: Dapeng Zhang <dapzhang@microsoft.com> Date: Mon Oct 25 10:19:25 2021 +0800 fix spellcheck for keyvault (#23638) commit e02305e242477c70c7b8457c1b60623673969c92 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Oct 22 15:07:22 2021 -0700 Fully automate cluster buildout. Add azure file share mount to stress tests. (#24882) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> commit 09097004fabfa8795202031fa00f5f4d7e8da494 Author: hivyas <61890270+hivyas@users.noreply.github.com> Date: Fri Oct 22 14:37:56 2021 -0700 [VideoAnalyzer] Updating sdk to 1.1 (#24800) * generated new models and updated sample * updated sample, readme, and changelog * addressing pr comments and exported api * renaming variable to address pr comment * removing en-us from link * changes based off pr comments commit e052b3b9f6916650a4e3472834ae1bf5cef87474 Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Fri Oct 22 12:44:58 2021 -0700 Allow setting nullable AMQP properties to null (#24880) commit f4913258f0fd7db99d40b0999fcc56f035b673ac Author: Mike Harder <mharder@microsoft.com> Date: Fri Oct 22 12:38:49 2021 -0700 [Perf] Add PerfTestBase and BatchPerfTest (#24653) - Made IPerfTest more generic to support additional test types - Added PostSetupAsync() and PreCleanupAsync() to support features like test-proxy - Added PerfTestBase for maximum control over test execution - Added BatchPerfTest for APIs which perform multiple operations per call - Moved most code from PerfTest to BatchPerfTest - Moved test-proxy, run loop, and collect metrics code from PerfProgram to BatchPerfTest - Added MockReceiverTest to validate BatchPerfTest - Preparing for addition of EventPerfTest in separate PR - No breaking changes to existing tests commit 8406d81100e9ba3b171fdf9d08896756e1e4132a Author: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Date: Fri Oct 22 12:20:24 2021 -0700 Fixed DataLakeUriBuilder to properly convert dfs or blob endpoints when those keywords were contained elsewhere (#24878) commit da4593d0f697973fe1f04d51e60adb1116ca8cff Author: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Date: Fri Oct 22 10:36:56 2021 -0700 Fixed Regression where ETags which had quotes surrounding the value, … (#23395) commit ec16f62bed854bba5f6ce1d3b4253bace78ac477 Author: liurunliang <vghfvyyg@hotmail.com> Date: Fri Oct 22 21:16:46 2021 +0800 Update Readme.md for Purview Catalog (#24866) Replace endpoint with https://<my-account-name>.purview.azure.com commit 99dac828a54c849c56b43c4b6fb922a609ce4125 Author: giakas <giakas@microsoft.com> Date: Fri Oct 22 03:47:53 2021 -0700 Update AVA SDK to use 2021-11-01 API version (#24873) * Update AVA SDK to use 2021-11-01 API version * revert an accidental change commit 6b82d7d988517b36baaae6eba6a0d710687fe835 Author: Martin Barnas <martinbarnas@microsoft.com> Date: Fri Oct 22 10:59:17 2021 +0200 remove private preview version (#24871) commit a84465f4968a1ddaf6976695a1429be1a5128b84 Author: Dapeng Zhang <dapzhang@microsoft.com> Date: Fri Oct 22 15:34:07 2021 +0800 Re record compute test cases (#24690) * re-record VM container * re-record vm operation tests * re-record compute test cases commit ee76ef8c57f2ee537502feddebdc2d1277835286 Author: Yao Kou <yaokou@microsoft.com> Date: Fri Oct 22 15:28:51 2021 +0800 fix issue 24840 (#24843) * fix issue 24840 * fix the sample link * fix the arm template docs link commit 88a4711af683c03d71798bfff1e652d9a71fa48d Author: JialinXin <jixin@microsoft.com> Date: Fri Oct 22 15:00:47 2021 +0800 [WebPubSub] Sync common properties. (#24862) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. commit dd28b5188dc2933c99911c910754106d021c5613 Author: JialinXin <jixin@microsoft.com> Date: Fri Oct 22 13:34:42 2021 +0800 [WebPubSub][Functions] Addressing some issue in tests and prepare GA. (#24858) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. commit 8c043963e3d306ce3d5a5e780a3a2b21cbce034d Author: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Date: Thu Oct 21 12:29:45 2021 -0700 [Search] Rename HighWaterMark to the more generic ChangeTrackingState (#24732) * Rename HighWaterMark to the more generic ChangeTrackingState * Update Changelog * Rename properties in `IndexerChangeTrackingState` * Rename parameters in `ModelFactory` class commit 5a7607f3355727b01e2811ea14e83ead1ebeaf0c Author: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Date: Thu Oct 21 12:16:25 2021 -0700 [WebPubSub] Generate code using '2021-10-01' version of the swagger (#24720) * Generate code using '2021-10-01' version of the swagger Add transforms to put methods in the public client Add service version 'V2021_10_01' and only keep the latest preview version Fix code because generated member `_endpoint` is `String` and not `Uri` * Rename GenerateClientAccessUri -> GetClientAccessUri commit 75672659abc064f72c1bd243a08ec18d967ecfc5 Author: Wes Haggard <weshaggard@users.noreply.github.com> Date: Thu Oct 21 11:16:15 2021 -0700 Remove unnecessary nuget.config file (#24848) * Remove unnecessary nuget.config file * Explicitly reference all packages needed by SignalR extension commit ee22836e0891378c9a7209b07a5692dc145ded3a Author: Anne Thompson <annelo@microsoft.com> Date: Thu Oct 21 09:59:12 2021 -0700 Add grow-up method for CheckPrincipalAccess (#24705) * Add grow-up method for CheckPrincipalAccess * change deserialization casing to match service; add tests * add cast to InModel and update grow-up method signatures to reflect new pattern commit 5a108ba4ef142ca90c40b1a29e05cfdf209aed52 Author: Martin Barnas <martinbarnas@microsoft.com> Date: Thu Oct 21 15:08:26 2021 +0200 rename method ExchangeTeamsToken to ExchangeTeamsUserAadToken (#24846) * rename method ExchangeTeamsToken to ExchangeTeamsUserAadToken * updated documentation * regenerated api * rename parameters and tests * regenerated test recordings * regenerate api commit f6cc06f2372c7d9d62e29251d082a471827a63a5 Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Date: Wed Oct 20 17:17:23 2021 -0700 Update GetExistingPackageVersions (#24825) commit 6fcdea8f472622ab84297c034e0e81daa653b047 Author: yzt <zityang@microsoft.com> Date: Thu Oct 21 07:29:03 2021 +0800 Add SignalR function extension (#24039) * The first commit of SignalR extension * Add ci.yml * fix * fix .gitignore * Remove Java code * Standardize `Directory.Build.props` and dependencies * Remove E2E tests Will add them later. * Remove js,java sample codes and rename directories * Rename .sln file * Rename `src/SignalRServiceExtension` to `src/Microsoft.Azure.WebJobs.Extensions.SignalRService` * Rename `test/SignalRServiceExtension.Tests` to `test/Microsoft.Azure.WebJobs.Extensions.SignalRService.Tests` * Rename `test` to `tests` * Remove unused items in sln file * Fix Protocols.csproj * Many fix * Remove Serverless protocol projects and move other codes * Fix target frameworks * Try fix code in srcs The problem is the $(RequiredTargetFrameworks) is netstandard2.0. But I need .net core 3.1. * Add SignalR nuget source for dev * Fix test project * Fix nuget source problem * Update `Packages.Data.props` * Remove `Management` project from `ci.yml` * Add `service.projects` * Remove samples * Add version and CHANGELOG.md * Fix docs * Fix readme. Add comparison of concept **SignalR Service client** and **SignalR client** * Export public APIs * Fix code snippets in readme * Fix warnings for src/* * Fix warnings for test/* * Add XML doc for public types * Remove unused file * Add code snippet for message trigger * remove gitignore file commit fe2c29de53f4ebc2b2a7c6196d26561aec61398d Author: James <41338290+jaschrep-msft@users.noreply.github.com> Date: Wed Oct 20 15:12:06 2021 -0700 etag lock once again passed down to wire (#24731) * etag lock once again passed down to wire * don't modify options in DownloadStreamingInternal * deep copy constructors * will no longer clone default * added null coalesce now that clone can return null Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> commit 6819082909e8c19b1d0097503c3ae5654e0d80f0 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Oct 20 12:06:49 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2093 (#24832) * Consume Codeowners parser library, ceperate users from teams in codeownerse * Update get-pr-owners and related logic Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit c706c4cca352c0416bba5e76b44aeb438d1488e6 Author: James <41338290+jaschrep-msft@users.noreply.github.com> Date: Wed Oct 20 11:41:37 2021 -0700 Set defaults to transactional hashing options (#24739) * Set defaults to transactional hashing options * record Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> commit c7e337df47b80c123b023352be6e39d81136ba81 Author: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Wed Oct 20 23:36:06 2021 +0800 Update AutoRest C# version (#24829) commit 7da9b9e3d6a0696155402be334d155ed814f7cb0 Author: AriZavala2 <77034370+AriZavala2@users.noreply.github.com> Date: Tue Oct 19 17:05:54 2021 -0700 Adding non-identity to .NET SDK (#24301) * Adding non-identity to .NET SDK * Add recordings * Update recordings * Update PR * Update PR * Update tests * Update * Update .NET PR * Update recordings * Add recordings for tests * Update recordings, updating names of tests so they don't repeat * Update PR * Remove unused snippet * Update CHANGELOG, readme and samples * Update changelog commit ae99a7ca4fdd8df913564b1a8167605351e762e6 Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 19 17:55:15 2021 -0500 replace commented Live tests (#24802) * replace commented Live tests commit 44f593e4fcfcbb17cef8defdc942da313cde05d7 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Oct 19 14:45:04 2021 -0700 update to latest test-proxy tag (#24820) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> commit d69cfbcfbee919f5cf9c3c4349dcf3f63f9450f7 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Oct 19 14:33:01 2021 -0700 Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#24822) commit e7c17aae18cf6205d94f9a42a64a66ef3dcbb01d Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 19 15:29:40 2021 -0500 handle json parsing errors (#24166) * handle json parsing errors commit f993f9d5a6062a04feedd7a72ac71dcb0c7ce77f Author: James <41338290+jaschrep-msft@users.noreply.github.com> Date: Tue Oct 19 10:49:13 2021 -0700 Client-side Encryption Added Test Coverage (#24797) * initial extra test * Forced-multipart upload/download encryption tests * undid formatting change * added stress test (ignored) Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> commit 724633562377b58815ccef8340ddff0ac6d7bec7 Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 19 09:10:55 2021 -0500 Doc typo in TableSasPermissions (#24816) commit c5738f34a5ded5bf4b49e380a8eec179e12a1c6b Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Oct 19 06:41:32 2021 -0700 Increment version for purview releases (#24813) Increment package version after release of Azure.Analytics.Purview.Administration commit e730a8f24a1c6f7c9f3f0f7518c141642382763c Author: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Tue Oct 19 15:24:21 2021 +0800 add ci config for Administration (#24810) commit 051b9691594b26f64cf95e10bee4872a6084e6b9 Author: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Tue Oct 19 14:59:51 2021 +0800 [Purview] Release Purview Administration (#24770) commit 186c119100ea507123c666481e904d366da17abf Author: subashchandra31 <66659771+subashchandra31@users.noreply.github.com> Date: Tue Oct 19 09:03:52 2021 +0530 2108 version changes (#24708) commit 8339a859be6b65d470617570a366c96a6d43b2e8 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Oct 18 19:54:03 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2085 (#24804) * Fix up identity resolver to make it more reliable, publish notification configuration as a tool * Use both username and email to resolve queuing user Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 2d103f78f26bdfb01eac4b1dba6ff19d6b765cd3 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Oct 18 16:09:37 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2100 (#24796) commit d9f64791ffc2af0d4bfde75ad5b0e7d118f0e0e5 Author: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Date: Mon Oct 18 16:05:04 2021 -0700 [Storage][Webjobs] Prepare Storage Webjobs Extension release. (#24794) * Prepare Storage Webjobs Extension release. * fix mixed reality recordings. * fix translation recordings. * API View feedback. * async. * oh lord... commit 1335b7d365e097fa759cf83c772a6a918b68eb0a Author: Heath Stewart <heaths@microsoft.com> Date: Mon Oct 18 15:07:31 2021 -0700 Fix Key Vault key rotation tests in other clouds (#24799) commit 25236cf742768158cbf02a4c1554d2e249808f84 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Oct 18 14:12:29 2021 -0700 adjust the docker-start-proxy to take advantage of the linux specific commands that allow contact of localhost (#24795) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> commit a455e394f7813b208405265667ab8144fb729f06 Author: Caio Saldanha <camaiaor@microsoft.com> Date: Mon Oct 18 13:10:43 2021 -0700 [EngSys] Sanitizing Storage secrets (#23584) commit 8f2f73e1c5e726a339c8c66b90aa01e3f3c732f7 Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Mon Oct 18 12:58:52 2021 -0700 Prepare for release of extensions (#24793) commit f0fc09a3f60d4034c4f0ad34ac4d66352e56199f Author: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Date: Mon Oct 18 12:44:24 2021 -0700 sanitize (#24775) commit 9f8730c87059e7b918bfe022360110e3cd26bb49 Author: Mike Harder <mharder@microsoft.com> Date: Mon Oct 18 12:33:26 2021 -0700 Remove duplicate code in RandomStream (#24762) commit df8a8c3c39856a42ca693e441003a5553c00a427 Author: Heath Stewart <heaths@microsoft.com> Date: Mon Oct 18 11:27:40 2021 -0700 Add Search index sample with complex field (#24654) Resolves #24014 commit d201976946052fffcc8682c0f77b38320b48adf1 Author: Christopher Scott <chriss@microsoft.com> Date: Mon Oct 18 12:44:51 2021 -0500 Support UInt64 for table entity properties (#24786) * Support UInt64 for table entity properties commit 1a7788c212fe39cf76b4df92dd6168a0659cb3f2 Author: Heath Stewart <heaths@microsoft.com> Date: Mon Oct 18 10:33:41 2021 -0700 Update System.Text.Encodings.Web (#24787) commit 9b308a88acf2db37d0fe5d68a8e40a111793c1dc Author: Mariana Rios Flores <mariari@microsoft.com> Date: Mon Oct 18 08:12:08 2021 -0700 add operation to test and sample (#24759) commit 8e5ad70668a2d3b059a918593c4b0a97b05de99b Author: Gyeonghun Park <gp112795@gmail.com> Date: Mon Oct 18 21:08:52 2021 +0900 Add Description Tag on DataFeedSource (#24764) commit e58222d235933c465df15ad60259a92c66df6135 Author: Mingzhe Huang <archerzz@users.noreply.github.com> Date: Mon Oct 18 15:33:11 2021 +0800 test(network): re-enable track2 mgmt tests (#24768) 1. re-record the tests for network track2 mgmt SDK 2. enable the ignored tests resolve #24577 commit 5885ba282477ea0eb1dd2a106cbbc0a3c8268224 Author: Yegun Kim <wlfka102@gmail.com> Date: Mon Oct 18 09:20:48 2021 +0900 [MetricsAdvisor] Simplify Utf8JsonWriterExtensions and follow pattern. (#24231) * Follow the pattern in https://github.com/Azure/autorest.csharp/blob/f790582c450f6f90e173a12e96c8e83a745a0b0f/src/assets/Generator.Shared/Utf8JsonWriterExtensions.cs#L52 * Simplify Utf8JsonWriterExtensions public methods (#24744) commit f2ca672c9e664908c27f11497dadacce411d2104 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sat Oct 16 06:34:17 2021 -0700 Increment package version after release of Azure.Analytics.Purview.Catalog (#24763) commit 7a8c4feed539f834ef5d30948284d1cc5be4c65d Author: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Sat Oct 16 10:04:06 2021 +0800 Update Purview Catalog (#24241) commit f6eb304be134a5035c6f095304f0faf63d5a3a17 Author: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Date: Fri Oct 15 16:31:44 2021 -0700 Update CopyStartSnapshotPositiveTest.json (#24760) commit f7eb5f10117bf96b01886c42cf9e68b5ffad56ff Author: Oren Michaely <35842001+orenmichaely@users.noreply.github.com> Date: Fri Oct 15 11:55:58 2021 -0700 [Personalizer] Change experimental unit duration to valid value in tests (#24741) * changed eud in tests * test failure * re-recorded multislot tests Co-authored-by: orenmichaely <73134189+ormichae@users.noreply.github.com> commit 339cedaf617fa986314c8faa3ef33a383c0397ec Author: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Date: Fri Oct 15 11:17:29 2021 -0700 Sanitize "accessSAS" and "packageUrl" in Track 1 Compute Tests (#24748) commit 24e88c20225517d852c161aa48272a765d5e4acb Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Oct 15 05:15:58 2021 -0700 Increment package version after release of Azure.Analytics.Purview.Scanning (#24751) commit 2796c0457b20a3208984abc548eb1280818ebf9e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Oct 15 05:15:19 2021 -0700 Increment version for tables releases (#24736) Increment package version after release of Azure.Data.Tables commit 83d12702901551a308912d90acd9c202c4d32c32 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Oct 15 05:14:23 2021 -0700 Increment version for identity releases (#24733) Increment package version after release of Azure.Identity commit 36c02ea1a3284486e9c4b798fab8689b99c98eb8 Author: Martin Barnas <martinbarnas@microsoft.com> Date: Fri Oct 15 10:29:31 2021 +0200 Martinbarnas/communication identity/2021 10 31 preview (#24665) update Communication Identity api to version 2021-10-31-preview to enable M365 Teams identities commit 21e199d5cd05c89899e5efc7ea7d38733c9e2d63 Author: JialinXin <jixin@microsoft.com> Date: Fri Oct 15 15:39:45 2021 +0800 [WebPubSub] Fix doc issue: #23669 (#24749) Fix doc issue: #23669 Update to latest doc link. commit 13187319dc7dfc28270f41917a785fec01342775 Author: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Fri Oct 15 14:47:45 2021 +0800 Update Puriew Scanning (#24242) commit efd201a3f3837ebe3c1d0868b29de8a61978012e Author: JialinXin <jixin@microsoft.com> Date: Fri Oct 15 14:06:50 2021 +0800 [WebPubSub] Remove dependency for Func Extension to prepare GA. (#24602) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. commit 441012ed26ce844e8f8195bc149103b9ce0f325c Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Thu Oct 14 17:14:47 2021 -0700 Increment version for keyvault releases (#24742) * Increment package version after release of Azure.Security.KeyVault.Certificates * Increment package version after release of Azure.Security.KeyVault.Administration * Increment package version after release of Azure.Security.KeyVault.Keys * Increment package version after release of Azure.Security.KeyVault.Secrets commit f8ef71ba8e275042a18b3e7adaa4792199c86437 Author: Heath Stewart <heaths@microsoft.com> Date: Thu Oct 14 15:20:16 2021 -0700 Prepare Key Vault release (#24740) commit 943b05e3a3dfc54aaeee000c77303b5072616ec2 Author: Heath Stewart <heaths@microsoft.com> Date: Thu Oct 14 14:47:00 2021 -0700 Support multi-tenant authentication in Key Vault (#24558) * Support multi-tenant authentication in Key Vault Resolves #18359 * Resolve PR feedback * Update to Azure.Identity 1.5.0 commit bbfa2b4ea6291da8cd20e919e5b7eaa3ade037df Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Thu Oct 14 13:33:15 2021 -0700 Allow accepting blank session (#24737) commit e92986748e5c3ec0442c60187c80c5ff534ec5e5 Author: Christopher Scott <chriss@microsoft.com> Date: Thu Oct 14 13:02:08 2021 -0500 Found last minute edge case - error in tests (#24734) commit 0740aec5b77dcaa0f6d8787473d3e10a03b8632d Author: Christopher Scott <chriss@microsoft.com> Date: Thu Oct 14 10:47:48 2021 -0500 Tables Oct patch release (#24730) commit 73d5f10e040e57dd8270ad1ff53849f33b5a2611 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Thu Oct 14 05:27:15 2021 -0700 Increment version for core releases (#24714) * Increment package version after release of Microsoft.Azure.Core.Spatial * Increment package version after release of Microsoft.Azure.Core.Spatial.NewtonsoftJson commit 1ac93d24ff329c0fe5fa8feac9e542eb62db2771 Author: Yao725 <yaokou@microsoft.com> Date: Thu Oct 14 13:15:04 2021 +0800 re-record resources package tests (#24721) commit 68184c5b93469daf4b1e07752678dd973b871572 Author: siriteja <32883500+sirireddy12@users.noreply.github.com> Date: Thu Oct 14 10:32:40 2021 +0530 Dotnet sdk generation for 2021-10-01 GA for Microsoft.Kubernetes (#24637) * dotnet sdk changes for 2021-10-01 GA * session recording files for tests * session recording files for tests * bumping sdk version * adding test records Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com> commit 30b4cd3c46707c4bbf150e3bba151a2ffe4e74d2 Author: joseph-porter <69636506+joseph-porter@users.noreply.github.com> Date: Wed Oct 13 22:39:30 2021 -0400 Update containerinstance client to 2021-09-01 API (#24713) * Generated files * Updating tags and versions * Updating tests commit 957ea65288a2046af2ca125ec2039e338a4fdbe4 Author: James <41338290+jaschrep-msft@users.noreply.github.com> Date: Wed Oct 13 15:08:56 2021 -0700 Feature/storage/transactional crc (#23056) * Transactional hashing models * StageBlock now has transactional hashing support * ContentHasher supports precalculated hash GetHash will now read all options and pull a possible precalculated hash into its response instead of calculating the result from scratch * New overloads appendblobclient and blockblobclient now have options bag overloads for their baseline upload methods. * Append and page blob updates Those clients now have new APIs for base uploads, deprecated old overloads, and updated writestreams to use the new internal signature. * Alligned XxxOpenWriteOptions for hashing options * Blob Write Streams Updated * uploadTransactionalHashing in datalake and shares * fixed mock issues Fixed how some mocks were constructed due to new signatures for some internal methods * blob download range transactional hashing * crc46 implementation and download tests * several read methods updated to transactional hash * testing * datalake/share download * build fix * renames | Blob/datalake downloadTo hashing * tests and fixes * Range required for download hashing testing, recording. * more tests. property renames for consistency. * Azure.Storage.Models => Azure.Storage Moved transactional hashing options classes down a namespace * fixes and rerecording transactional hashing tests * recording fix * recording * test fixes * all hashing tests scan messages for headers * minor fixes and test organization * test fine-tuning and rerecording * open write tests refactored for reusability * test refactors * More test refactoring * refactored parallel upload tests * finished blob test refactoring * exportapi * fix export * fixed a scope issue * fixed datalake.append scope and common mock * fixed mock setup * More mocking issues * irerecord * full rerecording transactional hash tests * revert force record mode * testing CI failure removing an inserted policy from hashing partitioned download tests to determine if it is interfering in recording interpretation. * Revert "testing CI failure" This reverts commit 4bbb8d378b548a6e59d0b416d5baa6b3f8124146. * made encryption/hashing test liveonly * datalake transactional hashing tests * port hashing tests to file shares * transactional hash arg validation * parallel upload doesn't accept precalculated hash * rerecord transactional hashing tests * restored accidental recording delete * rerecorded OpenRead tests * rerecord misc file share tests * New storagecrc64 API shape storage crc calculator prepared to inherit NonCryptographicHashAlgorithm when released. Static crc calculator converted to use ReadOnlySpan<byte> instead of byte[]. Static crc calculator converted to use BinaryPrimitives instead of BitConverter. NOTE this forces the calculation into a specific endianness which is acceptable based on CRC properties. * exportapi * misc pr feedback * Fixed a docstring * fixed diagnostic scope issue * Documented TransactionalHashingTestSkeletons.cs * test comments * Some PR responses Some options classes renamed GetHashResult memory optimizations. Disabled clientside crypto/hashing in combination * new downloadto options have consistent API shape * datalake hashing tests now use hns tenant * More PR comments * export api * new options bag APIs memory optimization * fixed failed tests * Initial hashing test conversion Converted TransactionalHashingTestSkeletons (collection of static helper methods) to TransactionalHashingTestBase : StorageTestBase. Tests are fully defined on this class. Subclasses per-client will implement abstract methods as instructions for uploads/downloads/etc., where before they were lambdas passed to the static helper methods every single time. * moved transactional hashing tests under new inheritance tree * deleted old hashing test session records * fixed playback bug and rerecorded to accomodate * Recorded inconclusive hashing tests * more recording inconclusive tests * quick fix * nitpicks/cleanup * ported v11 crc test * file header * reverted some auto IDE csproj changes * corrected a formating reversion * pr feedback * arg validation * pr feedback * Changelog Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> commit 5db70e92bd9942e42c6112e4c9f2a42cff0bedeb Author: Scott Schaab <sschaab@microsoft.com> Date: Wed Oct 13 14:34:39 2021 -0700 Make TokenCacheData.CacheBytes readonly per API review feedback (#24710) * Make TokenCacheData.CacheBytes readonly per API review feedback * update api spec commit ce2a35be142b1eda3db67ddba41e1d385631d432 Author: Scott Schaab <sschaab@microsoft.com> Date: Wed Oct 13 13:49:35 2021 -0700 Azure.Identity updating version and changelog for 1.5.0 release (#24673) commit a0200875d087451f614758f4842e60250589d381 Author: Heath Stewart <heaths@microsoft.com> Date: Wed Oct 13 12:40:21 2021 -0700 Update changelogs for Microsoft.Spatial converters (#24706) Forgot to suggest them in PRs #24520 and #24587 commit 2f182e61a8f616632c6733ef34f025aace35a09d Author: Christopher Scott <chriss@microsoft.com> Date: Wed Oct 13 13:14:34 2021 -0500 Support dboule.NaN (#24140) commit a80438c89885e7d6fbd431e241cdc0156a1f1aa8 Author: Heath Stewart <heaths@microsoft.com> Date: Wed Oct 13 11:11:57 2021 -0700 Reorder Key Vault code owners (#24704) Some tools seem to use the first person as the de facto owner. commit 9b713c2e406615b4c523091ff23e93b92e788a74 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Oct 13 10:43:52 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2095 (#24677) * Mitigate relative path calculation error on multiple iterations * Revert "Mitigate relative path calculation error on multiple iterations" This reverts commit 45baedd990c6a3085742a38a4891d8706a93be77. * GetRelativePath should check if path is already relative before calling [IO.Path]::GetRelativePath Co-authored-by: Daniel Jurek <djurek@microsoft.com> commit e2024fb3be3c20773d6dc86728d9eaa005ce33fa Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Wed Oct 13 10:11:43 2021 -0700 API updates for SB extension (#24678) commit 9fc0155d9e5762aa1accf0d7de03030829cb1e27 Author: Anne Thompson <annelo@microsoft.com> Date: Wed Oct 13 09:40:19 2021 -0700 [Synapse] Add grow-up method overload for GetRoleAssignmentById (#24600) * add first grow-up method * pr fb * nit * pr fb * update generated API * add async method and test for helpers * use project reference for core * update exported api * docstrings bug fix and pr fb commit 0e90588a13c184c74cf7059f73f2677a5b93b70e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Oct 13 05:41:25 2021 -0700 Update AutoRest C# version to 3.0.0-beta.20211012.1 (#24681) commit bc754ec5dada63ac6be9b00bb57cffafe178eb1e Author: Daeun Yim <69321306+DaeunYim@users.noreply.github.com> Date: Tue Oct 12 21:18:44 2021 -0700 [PostgreSQL] Release new SDK with updated API (#23662) * generated new postgres SDK * generate sdk * latest API change * PG generation * Trigger Build * Upgrade versions commit a949efa906149dd1f2a834156a00f9d04b203b6a Author: JialinXin <jixin@microsoft.com> Date: Wed Oct 13 11:29:12 2021 +0800 [WebPubSub] Fix API generate for WebPubSub Common. (#24660) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. commit ebd190d712419937ac45e8b129be154a052830d9 Author: Wan Yang <wanyang@microsoft.com> Date: Wed Oct 13 11:01:56 2021 +0800 [Synapse] management sdk release package-composite-v2 (#24588) * Oct. release * update for sql pool createmode commit a3678f2e36a25b244d5eebdd32d652f98d5369f4 Author: deymadhumanti <58032062+deymadhumanti@users.noreply.github.com> Date: Wed Oct 13 08:27:46 2021 +0530 Dot Net SDK related changes for 2021-07-01 API version for ResourceGuard (#24209) * Dot Net SDK related changes for 2021-07-01 API version for ResourceGuard * Fixing build break * Resolved PR comments * Resolved PR comments * Fixed build break Co-authored-by: Madhumanti Dey <madhude@microsoft.com> commit 38ec41c258fa2c992e174c8fa1815533326c2c34 Author: Nick Depinet <depinetnick@gmail.com> Date: Tue Oct 12 19:54:31 2021 -0700 update labservices sdk and tests for 2021-10-01-preview version (#24649) Co-authored-by: Nick Depinet <ndepinet@microsoft.com> commit b2043f7668405e4e181b5eeb28f6288580b43034 Author: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Date: Tue Oct 12 15:49:37 2021 -0700 Sanitize Leaked Secrets in Track 1 Compute Tests (#24661) commit 574cca2a158b6190e493cf67b35de4e5aaccbe3e Author: Mariana Rios Flores <mariari@microsoft.com> Date: Tue Oct 12 15:28:36 2021 -0700 [FR] Add post response to Operation classes (#24561) commit fc81eb789866effc487a429a778d1a1bc8a1b1ff Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Date: Tue Oct 12 15:20:33 2021 -0700 Move component governance to build step ti accomodate artifacts publisehd as part of the group (#24323) commit 064ee2d9a646362702476dc495a14578fc7ca020 Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Tue Oct 12 14:32:26 2021 -0700 Support binding to BinaryData (#24659) * Support binding to BinaryData * Add back accidentally removed testcase * PR FB commit 1c0fb6f2b8a299dde5693f782e89e82864657492 Author: Alexander Sher <AlexanderSher@users.noreply.github.com> Date: Tue Oct 12 15:23:37 2021 -0500 Update AutoRest C# version to 20211007.1 (#24567) * builds successful * Disable single value enum generation * Fix public API * Disable tests that need re-recording * Fix Synapse.AccessControl * Attempt to fix the build * update md file * Comment conflicting line * Update to 20211011.1: Azure.ResourceManager.Compute is not compilable. * Update public API and samples commit c39b496e3064ddcdae3054e54def6660909875e6 Author: Mariana Rios Flores <mariari@microsoft.com> Date: Tue Oct 12 13:21:13 2021 -0700 updating to merged swagger (#24675) commit 9ec66ae2436a00301c7ceae50bf6942978c486f5 Author: Mariana Rios Flores <mariari@microsoft.com> Date: Tue Oct 12 12:59:04 2021 -0700 [FR] Fix PercentageCompleted bug (#24569) commit 8ad561a0014492586a27e77f8cd466237616aef0 Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 12 14:14:52 2021 -0500 Hide AzureApplicationCredential (#24647) commit da407003bbab363a3818543ff9b0b9045d8e246b Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 12 14:14:35 2021 -0500 Identity readme updates (#24645) commit c232c9c8b4ee499298aebf4b31fcfc194bde321b Author: Mariana Rios Flores <mariari@microsoft.com> Date: Tue Oct 12 11:48:17 2021 -0700 make DocumentSignatureType an extensible enum (#24565) commit c1188fb456a494b5cf4957acb560d4bcf70a98d5 Author: Arcturus <dapzhang@microsoft.com> Date: Wed Oct 13 02:36:24 2021 +0800 Update and Regenerate Azure.ResourceManager.Compute (#24657) * update configuration so that shared gallery and all its silbings are non-resources now * refresh api commit ff84ead58b565b429a3d5f3a9e61268d34d25b43 Author: Christopher Scott <chriss@microsoft.com> Date: Tue Oct 12 12:19:09 2021 -0500 Fix ctor issue where Uri contains table name (#24668) commit 328f13daadc0277ed34c14679e19d92373522b40 Author: Jack Bond <jackhanbond@hotmail.com> Date: Tue Oct 12 12:22:00 2021 -0400 Expand spatial types supported by NewtonsoftJsonMicrosoftSpatialGeoJsonConverter. (#24587) * Added support for LineString, Polygon, MultiPoint, MultiLineString, MultiPolygon, and Collection. Code structure mirrors MicrosoftSpatialGeoJsonConverter. * Reworded and slightly restructured comments. Renamed variable. commit b150b82e1ece1452d30e8584f7f4943c2f1ec673 Author: JialinXin <jixin@microsoft.com> Date: Tue Oct 12 13:53:25 2021 +0800 [WebPubSub] Init the Microsoft.Azure.WebPubSub.Common proj. (#24359) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. commit dc94a67bd9a8bf22f880a32d61961a288d0e6186 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Oct 11 13:11:26 2021 -0700 Increment version for eventgrid releases (#24648) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventGrid commit 1900bd68d6e0f784608ee4d637ecf3c419cbe85c Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Mon Oct 11 12:10:29 2021 -0700 Prepare for release (#24646) commit 374120be9c7d4f5559c6d973d3716f88b3fc8cec Author: Christopher Scott <chriss@microsoft.com> Date: Mon Oct 11 13:28:47 2021 -0500 Chriss/token cache peristence options doc improvements (#23908) * Add example to TokenCachePersistenceOptions commit 33cfc7e84f7b5e38d59fa482370d3bc1e2cb98da Author: Christopher Scott <chriss@microsoft.com> Date: Mon Oct 11 13:26:03 2021 -0500 Add troubleshooting message link to credential exceptions (#23979) * Add troubleshooting message link to credential exceptions commit 84b65b04fbd7d491eb2fc73094e7719bc3bbf340 Author: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Date: Mon Oct 11 09:59:08 2021 -0700 Add Illumos (a Linux distro) to known words list (#24614) commit 8c8e502759b708e34eeae26ba3597f63130453be Author: Sagiv Frankel <sagivf@gmail.com> Date: Mon Oct 11 12:21:13 2021 +0300 [Kusto] Update to 2021-08-27 api-version (#24539) * update version in existing tests * New tests for network resources wip wip wip props description * Add constructor customization's Co-authored-by: Sagiv Frankel <safranke@microsoft.com> commit 8555426d25f08cdbc254f8584f7115276bb74ac1 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sat Oct 9 07:14:20 2021 -0700 Increment version for monitor releases (#24566) Increment package version after release of Azure.Monitor.Query commit 8b62898a20a8fbe82c2a2c548250c15fabf06a5e Author: aim-for-better <zhenyu.zhou@microsoft.com> Date: Sat Oct 9 11:10:00 2021 +0800 [HDInsight]Support new api version 2021-06-01 (#24581) * Fix Test code and custom code to algin with 2021-06-01 swagger change Add AZ test and private link related test Update the csproj and assembly info and AzSDK.RP.props * Regenerate source code * Update test and session records Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> commit ab46b82f35927aae7d347fed9846607ae5fbe2e1 Author: Theodore Chang <thchan@microsoft.com> Date: Sat Oct 9 02:31:55 2021 +0100 update version (#24386) commit f6afdee16a1958fa25f030a32b1b7ad104c0ac13 Author: Tianyun Gao (MSFT) <65581162+Tianyun-G@users.noreply.github.com> Date: Sat Oct 9 05:57:54 2021 +0800 Fix cloud events issue (#24585) commit af2eb8a74ab74aa73a763dc7b3a5478328e45c01 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Oct 8 14:50:28 2021 -0700 Avoid overwriting package info properties when dev version is added (#24564) Co-authored-by: Praveen Kuttappan <praveen.kuttappan@gmail.com> commit 23e95a8f2139347e8f623f148805863d982b3337 Author: Heath Stewart <heaths@microsoft.com> Date: Fri Oct 8 14:13:14 2021 -0700 Fix live Key Vault tests (#24593) * Fix live Key Vault tests The services for the attestation mock service container were conditioned, which required the `output` parameter to be conditioned and it wasn't. Initially testing locally with enableHsm=true so didn't catch it. * Ignore tests that unnecessary require Attestation Secure Key Release isn't yet supported on Key Vault, so ignore any tests that try to get this now-optional variable. commit 509cdb9b92308ea4a16c696daec239252fc031f0 Author: Heath Stewart <heaths@microsoft.com> Date: Fri Oct 8 13:26:42 2021 -0700 Stop building, testing deprecated Key Vault track 1 (#24595) commit 04b466d79d03d22bf4be16c88e16925b27d37b73 Author: Jack Bond <jackhanbond@hotmail.com> Date: Fri Oct 8 16:25:24 2021 -0400 Expand spatial types supported by MicrosoftSpatialGeoJsonConverter. (#24520) * Expand spatial types supported by MicrosoftSpatialGeoJsonConverter. * Added documentation. Cleaned up test data. * Expanded unit test discovered minor issue * Added Utf8JsonReaderExtensions which consolidates methods which extra data from a Utf8JsonReader. Tweaked comments. * Removed SkipComments. Tweaked exception messages. Updated Utf8JsonReaderExtensions method names. commit 253e98dbf0bd29ac1dc96063031fe8ed4cb81f83 Author: Caio Saldanha <camaiaor@microsoft.com> Date: Fri Oct 8 12:25:01 2021 -0700 [FormRecognizer] Implemented BoundingBox, DocumentField, and Operation live tests (#24555) commit f31b41b96bb08a5677994db3796183370796753f Author: Jesse Squire <jsquire@microsoft.com> Date: Fri Oct 8 13:10:26 2021 -0400 [Event Hubs] Buffered Producer Client Infrastructure (enqueue) (#24219) The focus of these changes is to continue fleshing out the buffered producer client, adding the ability to enqueue events to be published. Pending work: - Background management task - Background publishing task - Flush functionality - Clear functionality - Automatic partition assignment - Partition Key hashing commit c3d77a4c46fc0ec919e54ce48625adc5ce884a5f Author: Jesse Squire <jsquire@microsoft.com> Date: Fri Oct 8 12:46:52 2021 -0400 [Event Hubs] Minor Fixes (#24590) The focus of these changes is a set of minor fixes, including: - Fixing the flaky `LoadBalancingAppliesTheGreedyStrategy` test - Logging the selected event position when a partition is initialized - Removing an outdated and incorrect set of remarks. commit 8b7faa7ee0e948dd762976e4c1b155e18abc9bf3 Author: kingsleyAzure <wangyueren1@hotmail.com> Date: Fri Oct 8 02:24:44 2021 -0700 Regenerate .Net SDK for TDE Api (#24138) * generating TDE .NET Api * fix DatabaseCrudTest * add session records * add more session records * add more fix to session records * disable failed tests which does not related to TDE * bump csharp version from 79 to 82 * bump sdk version to 2.0.0.0 Co-authored-by: Yueren Wang <yuerenwa@microsoft.com> commit 31682a20940b02437740ce2f579440c396a8a067 Author: Jingshu923 <52914166+Jingshu923@users.noreply.github.com> Date: Fri Oct 8 14:45:33 2021 +0800 [DataFactory]Added new features into 4.26.0 (#24579) * [DataFactory]Supported AmazonRdsForOracle Source * [DataFactory]Added new features into 4.25.0 * [DataFactory]Added new features into 4.26.0 commit 93f8af5ac2fa7ce4887540547c6e62708a4d432a Author: Faisal Al Tell <88511949+faisalaltell@users.noreply.github.com> Date: Thu Oct 7 22:10:15 2021 -0700 Publish .NET SDK for new version 2021-08-01 (#24177) * run generate.ps1 to update sdk * fix run for generate.ps1 * Run generate.ps1 v2 * Update AzSdk.RP.props, DataShare.cproj and AssemblyInfo.cs files Co-authored-by: Anniruddh Koppal <ankoppal@microsoft.com> commit 48ad7248979ef207753370d494908ec240a90d2e Author: Ajay Parulekar <79739098+ajparule@users.noreply.github.com> Date: Fri Oct 8 08:06:19 2021 +0530 [CosmosDB]Dot Net SDK for 2021-07-01-preview api version (#24269) * Autorest generated code + fix test + add cassandra view test * Test Fix * updated the version & release notes * Fix Discrepancy detected between generated code in PR and reference generation commit 17d224f28b93eb0c7df07f62aee3c58ab5523d38 Author: Paymaun <Paymaunh@microsoft.com> Date: Thu Oct 7 17:59:47 2021 -0700 Refactor how DMR client supports metadata configuration. (#24560) * Address feedback wave. commit 98ee5c2d0df9cea58a789e9671b2599533c079f4 Author: Heath Stewart <heaths@microsoft.com> Date: Thu Oct 7 17:08:18 2021 -0700 Deploy mock attestation container (#24573) Resolves #23515 commit b3f58b4b184708cb62749e33b73799babde7dfb6 Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Date: Thu Oct 7 17:02:47 2021 -0700 Fix CRUD tests (#24557) * Fix CRUD tests * Update dependencies commit 227a393ede39ebee2aecde825bc690912bffefd7 Author: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Date: Thu Oct 7 15:55:03 2021 -0700 [Storage][Webjobs] Fix dynamic sku. (#24568) * Fix dynamic sku... * move tests to common test package. * spelling. commit 628b41c32fc59f67234359210b691dc9e487f7c7 Author: DorothySun216 <55454966+DorothySun216@users.noreply.github.com> Date: Thu Oct 7 15:41:35 2021 -0700 Allow receiving empty string session id sessions (#24570) * add changelog for a new nuget minor version bump * Revert "add changelog for a new nuget minor version bump" This reverts commit 7ece7b55ea4e6d7af11fcb63a21bb9dd39373e53. * add change log for amqp lib update * try to run failed tests * try to fix the flaky test * try to fix the flaky test * clean up unnecessary comments * make timeout a configurable parameter for test * remove empty string check for session id on receiving path commit d61e04c915fd894cf1ca6d1456a315dc2a105d69 Author: Anne Thompson <annelo@microsoft.com> Date: Thu Oct 7 15:22:03 2021 -0700 Generate Synapse AccessControl LLC (#24364) * generate AccessControl LLC * update api listing * remove snippets from AccessControl * remove AccessControl snippets * WIP - tests compile on LLC but don't pass * fix incorrectly written request body * restore samples and snippets * update snippets *…

Release machinelearningservices microsoft.machine learning services 2023 08 01 preview (Azure#24762) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-06-01-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-08-01-preview mfe.json (Azure#24764) * add mfe.json * labeling jobs update descriptions * add examples for ServerlessEndpoint * update labelingjob examples * label job examples remove additional properties * adding sku to patch * add identity to patch * add in operationresult to examples --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Adding Resources at sweep level (Azure#25090) Co-authored-by: Anubha98 <anubhajain@microsoft.com> * HoboVM Preview Features (Azure#24769) * Update Pricesheet properties for savingsPlan (Azure#24708) * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update consumption.json * Update consumption.json * Update PriceSheet.json * elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (Azure#24494) * Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Added PE related changes * Added Private Link resource API * Nit change to correct the path for privateLinkResource API * Updated Lint errors * prettier check * resolved comments & added publicNetworkAccess * removed publicNetworkAccess & NIT changes * Updated the list operations * resolved lintDiff * proper value for examples and removed value from PECollections * resolved comments * spell check resolved * removing volumeCreateParameter * [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (Azure#24390) * add or modify files * Updated `credentials` models according to PR Azure#24318 + reverted unwanted changes to `readme.md` * Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value * Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties` * improve NR Examples (Azure#24636) * improve NR Examples * addressing AutoRun Errors * Fixing Prettier Issue * Adding NextLink in Max Examples * Formatting Azure Resource Id * Updating Format of azure subscriptionIds * update code owner (Azure#24754) * Update readme.python.md (Azure#24758) * [TypeSpecValidation] Refactor package.json (Azure#24756) - Improves upon Azure#24745 - Creates eng/tools/package.json for all EngSys tools - Moves "postinstall" to eng/tools/TypeSpecValidation/package.json - Technically incorrect if the package were ever to be published to a registry - In practice, the best way I have found so far to use source-based tools in a TypeScript repo * Add resize APIs * workflow-bot comments: update breaking changes alternative C to point to alternative B (Azure#24770) * Add properties for os patching (Azure#24775) Co-authored-by: Chris Jiang <chrjia@microsoft.com> * [Communication] Job Router Public Preview v2022-07-18 (Azure#23804) * Updated JR swagger with maxNumberOfJobs * job scheduling swagger changes * Enforce DistributionMode.kind to be read-only * retry with removing Required tag from abstract property for DistributionMode * WorkerState stopped showing up in generated swagger * Add reofferTimeUtc to decline offer API * Prettier * Prettier * rename WorkerState to RouterWorkerState * more fixes in polymorphic types * Rename decline offer request * prettier fix * add example for scheduled job * cpsell fix * fix response schema validation error * address review feedback item round 1 * SDK review changes * More API changes * Update distribution mode required properties * Renamings * job matching mode added * prettier fixes * fix examples refs * update ref examples * update swagger spec * fix enum mismatch * change operator to labelOperator in classification policy get and update ops example * Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json Co-authored-by: Liangying.Wei <lianwei@microsoft.com> * hide redundant communicationerror and communicationerrorresponse during codegen * revert commit * fix typo * test whether removing kind from request works * revert removing kind from request * make kind read-only * run prettier * try adding properties to empty classes --------- Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> * [OpenAI] Rename properties for Java (Azure#24596) * renames * more renames * testing on the deploymentOrModelName * revert for no breaking changes * [TypeSpec] Upgrade to 0.46.0 (Azure#24776) * Release quota on stop (Azure#24778) * Release quota on stop * add ReleaseQuotaOnStop to computeinstance properties * update * rm * [OpenAI] Update generated autorest (Azure#24788) - Continuation of Azure#24596 * Dynatrace.Observability merge to public repo (Azure#24101) * Initial Commit * Updating version in all files * Removed version from readme * removing version which are not available from readme * Resolving PR comments (Azure#24205) * Features/users/abhargava/merge to public repo (Azure#24230) * Resolving PR comments * Features/users/abhargava/merge to public repo (Azure#24233) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Features/users/abhargava/merge to public repo (Azure#24253) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Added a suppression for Avacado issue * Adding the required field * Updating suppression reason * Updating path for suppression * Adding suppression for deprecated API * suppression * suppress * Update specification/dynatrace/resource-manager/readme.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * updating path in suppression * updating suppression * updating suppression * Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions Iteratively work on fixing suppressions * Update readme.md: update suppressions * Update readme.md: update suppressions * Update readme.md: remove Avocado suppressions --------- Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Double Header Fix (Azure#24760) * [OpenAI.Inference] Adding content filter support (Azure#24652) * first-pass adding annotation * FilterResult definitions * move Filter definitions to common * cleaning up naming and imports * adding version headers * added descriptions to objects * correct self_harm JSON projection * Correct to "prompt_annotations" * "prompt_annotations" for chat, too * Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Add per-choice content_filter_results to /completions * tsp compile after merge * recompile with 0.46.0 after today's update --------- Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Update OpenAI PR assignment (Azure#24794) * Update OpenAI PR assignment * Update pull_request_assignment.yml * [typespec-ci] Automatically detect spec folders to validate (Azure#24629) * [fist] mgmt, update service name (Azure#24781) * [typespec-pr] Add pipeline (Azure#24802) * [typespec-ci] Remove path wildcard (Azure#24804) * Update engsys CODEOWNERS (Azure#24808) * Align optionality of content filter categories (Azure#24819) * Add spec ARM PR review workflow diagram to ARM PR description template. (Azure#24823) * Add spec PR review workflow diagram to ARM PR description template. * Update control_plane_template.md: fix link to diagram (Azure#24828) * Added generator config for OpenAI `Functions` for the Java SDK (Azure#24765) * Remove repeatability support for token revocation endpoint (Azure#24589) * Update clientTYpe (Azure#24503) * [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#24048) * Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (Azure#23832)" (Azure#23923)" This reverts commit e6c0e188a74d051a3a44728ce058e85447553392. * Removed 202 and Async supression. * Update documentation. * Updated documentation --------- Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> * [package-lock.json] Add names to local dependencies (Azure#24846) - Command "npm update" removes these names, but "npm install" adds them - It's probably better to keep the names, since users are more likely to run "npm install" * Update ci-fix.md: add API Doc Preview TSG (Azure#24843) * Update ci-fix.md: add API Doc Preview TSG * Remove unsupported SQL Pool Rename/move operation (Azure#24517) * Add enableOSPatching and address comments (Azure#24849) * Updated text for property isSoftDeleteFeatureStateEditable (Azure#24713) * Updating folder structure for Microsoft.Migrate (Azure#24550) * folders restructure and update readme * revert removed offazure in readme * Removing readonly flag from top level object (Azure#24848) * [ACS JobRouter] Add misssing descriptions (#24842) * Updated JR swagger with maxNumberOfJobs * sync with upstream main * add descriptions * prettier fix * add more missing descriptions * add more description fixes --------- Co-authored-by: williamzhao87 <williamzhao87@gmail.com> * a couple of representation tweaks for codegen (Azure#24847) * Removed pricing not relevant to CI * Added Resizing state * Change targetVMSize name * Revert "Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs into teom-hobovm08-01-preview" This reverts commit 47adff637482e53956bcde7a4331f0638a1ddfbc, reversing changes made to 4b9165da959a09109ecf96e7e70a940ec3989732. * Resolve comments for os patching (Azure#24872) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * Rename osPatchingStatus to upper case (Azure#24954) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * Fix some minor issues * Fix comments * Minor changes * Fix more builds * 200 and nextLink * Remove nextlink * Try 204 not 200 * Change GET call to POST * Remove 204 * Add 200 response * Change example state * Add enum for patch status (Azure#25208) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> * LRO does not return 200 * Format readme * Format readme * Format readme * Fix readme * Rename enum for patchStatus (Azure#25257) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status * rename enum's name * rename enum --------- Co-authored-by: Chris Jiang <chrjia@microsoft.com> --------- Co-authored-by: Jayati Tehri <72947097+jayati-tehri@users.noreply.github.com> Co-authored-by: PreetPRG <31791038+PreetPRG@users.noreply.github.com> Co-authored-by: InbalZim <48387592+InbalZim@users.noreply.github.com> Co-authored-by: VIPRAY JAIN <118152689+vipray-ms@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: Chris Jiang <hust.crystal@gmail.com> Co-authored-by: Chris Jiang <chrjia@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com> Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: mqwang <mewan@microsoft.com> Co-authored-by: abhargavams <91880511+abhargavams@users.noreply.github.com> Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: Brandon Miller <42854725+brandom-msft@users.noreply.github.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Albert Cheng <38804567+ckairen@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Daniel Hu <dhu5432@gmail.com> Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com> Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> Co-authored-by: kashyap-kunal <72463758+kashyap-kunal@users.noreply.github.com> Co-authored-by: ishanjindalms <96572678+ishanjindalms@users.noreply.github.com> Co-authored-by: athulvijayanmsft <134380821+athulvijayanmsft@users.noreply.github.com> Co-authored-by: Thomas Ricci <thricci@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@gmail.com> * Adding new query param on list job api (Azure#25375) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * Remove list materialization jobs api (Azure#25372) * Update mfe.json * prettify swagger * Remove example * Update readme.md * Update readme.md * Add backfill api contract changes * Fixing json * Add property bag * Modifying example --------- Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * sweep over pipeline component (Azure#25616) * Add SSO and RootAccess (Azure#25754) Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * add EnvironmentVariables in sparkjob (Azure#25814) * Add model monitor 2023-08-01-preview changes (Azure#25785) * Add model monitor 2023-08-01-preview changes * update * run prettier * update comments * add * Add WS Vnet properties for Serverless GA (Azure#25780) * add serverless ws vnet properties * add to workspace update properties * update format * update description --------- Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> * Resource to ProxyResource for preview version (Azure#25906) Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> * August-2023-preview fix circular reference (Azure#25870) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Update ServerlessEndpoints design (Azure#25593) * first draft redesign of ServerlessEndpoints * add getStatus.json * update examples * add LRO location header to example * add CapacityReservationGroups API * spellcheck fix * example fix * capacity reservation groups should be under resource groups * fix examples * inferenceUri -> uri * CapacityReservation -> ServerlessEndpointCapacityReservation * update description * remove ExcessCapacityReservation concept * remove parentGroupId concept * rename /status api to /getStatus * label metrics as readOnly * lintdiff GET fix * more fixes * add listBySubscription * add/fix examples * add suppression for lint error (Azure#25941) * minor fixes (Azure#25940) * Update 2023-08-01-preview swagger for workspaceRP (Azure#25532) * Update swagger * Bug fix * update * Update testconnection and example * Fix format * update custom words and example * Update missing custom words * reflect comment remove LRO opetions * make metadata a string dictionary * reflect comment * Revert "reflect comment" This reverts commit 9b85252250fd442dd891b27509f5d2e315d8aa2a. * Update with managedNetwork change included * Update managed network schema * revert metadata change * remove the RBAC properties related with shared connection * Update readme * Update suppression reason * Updated preview API to add Kernel Config (Azure#25361) * Updated preview API to add Kernel Config and LRO Headers * Fixing formatting issue * Updated as per comments * Updated as per comments * Reverting changes * Reverted header changes * Reverting change * Reverting example * Added version parameter and removed addition properties as per guidelines --------- Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> * Thtodoro/serverless endpoints 2023 08 01 preview fix (Azure#25993) * Capacity Reservation Groups is not an async resource, and thus does not have 202 as a response type * PATCH response must have same resource as GET/PUT APIs * add missing description * Adding Inference Pools, Groups and Endpoints recreated for Azure/azure-rest-api-specs#25783 for rebased issue (Azure#25819) * Adding Inference Pools, Groups and Endpoints * PR comments * remove EventLog and change data * remove EventLog and change data * moving endpoint as sibling to group * Moving back to the tracked resources * force change * fix the missing field --------- Co-authored-by: Raushan Kumar <raushank@microsoft.com> * Make suppression more specific (Azure#26031) Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> * add serverless compute settings (Azure#26007) Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: Anubha Jain <41411445+Anubha98@users.noreply.github.com> Co-authored-by: Anubha98 <anubhajain@microsoft.com> Co-authored-by: teochaban <teochaban@hotmail.com> Co-authored-by: Jayati Tehri <72947097+jayati-tehri@users.noreply.github.com> Co-authored-by: PreetPRG <31791038+PreetPRG@users.noreply.github.com> Co-authored-by: InbalZim <48387592+InbalZim@users.noreply.github.com> Co-authored-by: VIPRAY JAIN <118152689+vipray-ms@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Teo Magnino Chaban <teom@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: Chris Jiang <hust.crystal@gmail.com> Co-authored-by: Chris Jiang <chrjia@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com> Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com> Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: mqwang <mewan@microsoft.com> Co-authored-by: abhargavams <91880511+abhargavams@users.noreply.github.com> Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: Brandon Miller <42854725+brandom-msft@users.noreply.github.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Albert Cheng <38804567+ckairen@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Daniel Hu <dhu5432@gmail.com> Co-authored-by: Kalpesh Chavan <18593210+KalpeshChavan12@users.noreply.github.com> Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com> Co-authored-by: kashyap-kunal <72463758+kashyap-kunal@users.noreply.github.com> Co-authored-by: ishanjindalms <96572678+ishanjindalms@users.noreply.github.com> Co-authored-by: athulvijayanmsft <134380821+athulvijayanmsft@users.noreply.github.com> Co-authored-by: Thomas Ricci <thricci@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@gmail.com> Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com> Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: ghsutirtha <87542976+ghsutirtha@users.noreply.github.com> Co-authored-by: ycheng35xo <90874573+ycheng35xo@users.noreply.github.com> Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com> Co-authored-by: ac923 <aahelic@yahoo.com> Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: srivatsasinha <102133347+srivatsasinha@users.noreply.github.com> Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com> Co-authored-by: Raushan Kumar <44377286+raushan2016@users.noreply.github.com> Co-authored-by: Raushan Kumar <raushank@microsoft.com>

Prevent ObjectDisposedException if disposed twice

3a90dd3

Prevent ObjectDisposeException if AzureKeyVaultConfigurationProvider is disposed of more than once. See dotnet/aspnetcore#37631.

martincostello requested a review from pakrym as a code owner October 17, 2021 17:44

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 17, 2021

ghost added the Community Contribution Community members are working on the issue label Oct 17, 2021

pakrym approved these changes Oct 25, 2021

View reviewed changes

pakrym merged commit f6319e4 into Azure:main Oct 25, 2021

martincostello deleted the Fix-ObjectDisposedException branch October 25, 2021 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent ObjectDisposedException if Key Vault config provider disposed twice #24769

Prevent ObjectDisposedException if Key Vault config provider disposed twice #24769

martincostello commented Oct 17, 2021

ghost commented Oct 17, 2021

pakrym commented Oct 25, 2021

Prevent ObjectDisposedException if Key Vault config provider disposed twice #24769

Prevent ObjectDisposedException if Key Vault config provider disposed twice #24769

Conversation

martincostello commented Oct 17, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

ghost commented Oct 17, 2021

pakrym commented Oct 25, 2021