Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage mgmt test #25395

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Add storage mgmt test #25395

merged 5 commits into from
Nov 18, 2021

Conversation

yukun-dong
Copy link
Contributor

All SDK Contribution checklist:

This PR adds PrivateEndpointConnection tests and tests from track1.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Nov 18, 2021
@yukun-dong yukun-dong marked this pull request as ready for review November 18, 2021 08:06
@archerzz archerzz merged commit 4df7a87 into Azure:main Nov 18, 2021
yukun-dong added a commit that referenced this pull request Nov 19, 2021
* [SignalR] Add Strongly typed serverless hub (#25075)

# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [x] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [x] Pull request includes test coverage for the included changes.

* Increment version for operationalinsights releases (#25345)

Increment package version after release of Microsoft.Azure.OperationalInsights

* [ACR] Update SDK to c8d9a26a of REST spec (#24341)

* Generate changes before any transforms

* Regenerate code after adding transforms

* Update internal interface and cleanup removed properties

* Update public API

* Update service version and test session records

* Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()`
Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null.

* Update public API

* Update session records

* Update Changelog

* Sync eng/common directory with azure-sdk-tools for PR 2290 (#25372)

* update docker-start-proxy to have a slightly different default parameter

* we were surrounding the value in single quotes, breaking recording load

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* [Event Hubs] Flaky Test Fix (#25346)

The focus of these changes is to stabilize some tests with non-deterministic
behavior that have recently shown to be flaky when run in CI pipelines.

* [Azure.Core] Logging Sample Enhancement (#25389)

# Summary

The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`.  We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs.

* [LLC] Implement RequestOptions.AddPolicy (#25214)

* add test for AddPolicy

* share proposed refactoring to HttpPipelineExtensions

* ideas in the direction of implementation

* mark retry policy

* revert mark retry policy

* shifting API around

* experiment with using MemoryPool

* use ArrayPool

* use ArrayPool

* add tests

* update API

* throw if didn't use pipeline builder

* pr feedback and merge follow-up

* pr fb and merge follow-up

* pr fb

* simplify request pipeline creation

* move AddPolicy tests to Core; pr fb

* nit

* pr fb

* pr fb & fix build

* pr fb

* pr fb & build fix

* pr fb

* pr fb

* pr fb & fix core ci

* Update CODEOWNERS (#25393)

* Microsoft.Azure.Management.Avs 3.0.0 (#25276)

* use main branch

* generated for 2021-12-01 API

* switch AvsTests to test mock_api server

* Updating recorded test files also tested with playback

* generate from main

* set to 3.0.0

* Updating test records for AVS/2021-12

* Updating new test records

* Updated test records

Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com>

* KeyVault Preview 2021 06 (#25282)

* Generated new code from 06-preview version

* Regenerated code to pick up additional changes.

* Update unit tests for 2021-06-01-preview and SystemData

* updated metadata

* Updated package version to 4.0.0-preview.1

Co-authored-by: Soohwan Kim <sookim@microsoft.com>
Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com>

* Increment version for containerregistry releases (#25397)

Increment package version after release of Azure.Containers.ContainerRegistry

* Add storage mgmt test (#25395)

* add tests from track1

* add and modify some tests

add tests

modify tests

* ignore PITR test case

* ignore PrivateEndpointConnection tests

* Update changelog for AddPolicy (#25394)

* [Event Hubs] Sample updates for the Buffered Producer (#25388)

* [Event Hubs] Sample updates for the Buffered Producer

The focus of these changes is to incorporate the `EventHubBufferedProducer`
client into the Event Hubs samples for client types and publishing.  Also
included is a clarification for the logging sample, calling out the lifetime
needs for the listener.

* TURN: Adding RouteType optional parameter to GetRelayConfiguration (#25032)

* Add Anycast parameter to GetRelayConfiguration

* Update PR, removing unused snippet.

* Modified swagger, so adding new autogenerated code

* Update PR

* Update PR, add new recordings, reenable non-identity tests

* Adding GetRelayOptions and updating Readme and changelog

* Update PR

* Update PR

* [MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540)

* Fix CanSetContentLengthOverMaxInt (#25404)

* Update changelog removing unused sections (#25413)

* [template-LLC] Rename LLC to Dataplane Code Gen (#25390)

* Rename LLC to Dataplane Code Gen

* [Event Hubs] Buffered Producer Tweaks and Test Fixes (#25415)

The focus of these changes is to trim some unused logic for enqueuing events,
add some missing mock setups to guard against a test race, and improve some
minor test structure.

* Fix Broken link in EventGrid ReadMe (#25417)

* [MetricsAdvisor] Moving to new MA resource (#25406)

* Add Bryce into CodeOwners for IoT SDK team (#25420)

* fix test error; update snippets

Co-authored-by: yzt <zityang@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Jesse Squire <jsquire@microsoft.com>
Co-authored-by: Anne Thompson <annelo@microsoft.com>
Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com>
Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com>
Co-authored-by: Soohwan Kim <sookim@microsoft.com>
Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com>
Co-authored-by: AriZavala2 <77034370+AriZavala2@users.noreply.github.com>
Co-authored-by: Gyeonghun Park <gp112795@gmail.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com>
Co-authored-by: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Co-authored-by: Caio Saldanha <camaiaor@microsoft.com>
Co-authored-by: brycewang-microsoft <94650966+brycewang-microsoft@users.noreply.github.com>
@yukun-dong yukun-dong deleted the add-test-storage-mgmt branch November 19, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants