Fix Broken link in EventGrid ReadMe #25417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chidozieononiwu
commented
Nov 18, 2021
chidozieononiwu
commented
- Fixing broken link.
chidozieononiwu
requested review from
ahamad-MS,
jfggdl,
JoshLove-msft and
Kishp01
as code owners
ghost
added
the
JoshLove-msft
approved these changes
Nov 18, 2021
yukun-dong
added a commit
that referenced
this pull request
Nov 19, 2021
* [SignalR] Add Strongly typed serverless hub (#25075) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [x] Pull request includes test coverage for the included changes. * Increment version for operationalinsights releases (#25345) Increment package version after release of Microsoft.Azure.OperationalInsights * [ACR] Update SDK to c8d9a26a of REST spec (#24341) * Generate changes before any transforms * Regenerate code after adding transforms * Update internal interface and cleanup removed properties * Update public API * Update service version and test session records * Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()` Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null. * Update public API * Update session records * Update Changelog * Sync eng/common directory with azure-sdk-tools for PR 2290 (#25372) * update docker-start-proxy to have a slightly different default parameter * we were surrounding the value in single quotes, breaking recording load Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * [Event Hubs] Flaky Test Fix (#25346) The focus of these changes is to stabilize some tests with non-deterministic behavior that have recently shown to be flaky when run in CI pipelines. * [Azure.Core] Logging Sample Enhancement (#25389) # Summary The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`. We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs. * [LLC] Implement RequestOptions.AddPolicy (#25214) * add test for AddPolicy * share proposed refactoring to HttpPipelineExtensions * ideas in the direction of implementation * mark retry policy * revert mark retry policy * shifting API around * experiment with using MemoryPool * use ArrayPool * use ArrayPool * add tests * update API * throw if didn't use pipeline builder * pr feedback and merge follow-up * pr fb and merge follow-up * pr fb * simplify request pipeline creation * move AddPolicy tests to Core; pr fb * nit * pr fb * pr fb & fix build * pr fb * pr fb & build fix * pr fb * pr fb * pr fb & fix core ci * Update CODEOWNERS (#25393) * Microsoft.Azure.Management.Avs 3.0.0 (#25276) * use main branch * generated for 2021-12-01 API * switch AvsTests to test mock_api server * Updating recorded test files also tested with playback * generate from main * set to 3.0.0 * Updating test records for AVS/2021-12 * Updating new test records * Updated test records Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com> * KeyVault Preview 2021 06 (#25282) * Generated new code from 06-preview version * Regenerated code to pick up additional changes. * Update unit tests for 2021-06-01-preview and SystemData * updated metadata * Updated package version to 4.0.0-preview.1 Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com> * Increment version for containerregistry releases (#25397) Increment package version after release of Azure.Containers.ContainerRegistry * Add storage mgmt test (#25395) * add tests from track1 * add and modify some tests add tests modify tests * ignore PITR test case * ignore PrivateEndpointConnection tests * Update changelog for AddPolicy (#25394) * [Event Hubs] Sample updates for the Buffered Producer (#25388) * [Event Hubs] Sample updates for the Buffered Producer The focus of these changes is to incorporate the `EventHubBufferedProducer` client into the Event Hubs samples for client types and publishing. Also included is a clarification for the logging sample, calling out the lifetime needs for the listener. * TURN: Adding RouteType optional parameter to GetRelayConfiguration (#25032) * Add Anycast parameter to GetRelayConfiguration * Update PR, removing unused snippet. * Modified swagger, so adding new autogenerated code * Update PR * Update PR, add new recordings, reenable non-identity tests * Adding GetRelayOptions and updating Readme and changelog * Update PR * Update PR * [MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540) * Fix CanSetContentLengthOverMaxInt (#25404) * Update changelog removing unused sections (#25413) * [template-LLC] Rename LLC to Dataplane Code Gen (#25390) * Rename LLC to Dataplane Code Gen * [Event Hubs] Buffered Producer Tweaks and Test Fixes (#25415) The focus of these changes is to trim some unused logic for enqueuing events, add some missing mock setups to guard against a test race, and improve some minor test structure. * Fix Broken link in EventGrid ReadMe (#25417) * [MetricsAdvisor] Moving to new MA resource (#25406) * Add Bryce into CodeOwners for IoT SDK team (#25420) * fix test error; update snippets Co-authored-by: yzt <zityang@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Anne Thompson <annelo@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com> Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com> Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com> Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com> Co-authored-by: AriZavala2 <77034370+AriZavala2@users.noreply.github.com> Co-authored-by: Gyeonghun Park <gp112795@gmail.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Caio Saldanha <camaiaor@microsoft.com> Co-authored-by: brycewang-microsoft <94650966+brycewang-microsoft@users.noreply.github.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 19, 2023
[Hub Generated] Review request for Microsoft.Migrate/AssessmentProjects to add version stable/2023-03-15 (Azure#25417) * Adds base for updating Microsoft.Migrate/AssessmentProjects from version stable/2019-10-01 to version 2023-03-15 * Updates readme * Updates API version in new specs and examples * edit * added types files * added examples * edit. spelling ignore words added * edit. api version fix * edit. * edit. * edit. * deleted zombie files and ran prettier * removed data plane folder to fix checks * Removed common types folder. * Fixed relative path to common types + minor swagger edits * removed 2019 from default tag to fix go sdk check * edit * minor swagger fixes * edit * edited string for policheck * minor fix * Added manual examples * fixed errors in checks * testing update readme to latest API version * edit * edit * compile swagger with new typespec compiler version * edit * Sdded PE resources using common types * added regex pattern * edit * edit * edit * edit. minor changes from comments/ checks * cleanup * made delete sync and updated examples * edit. made string to date time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.