Rewind stream in test before reading #49818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaschrep-msft
requested review from
amnguye,
jalauzon-msft,
nickliu-msft,
schaabs,
seanmcc-msft and
tg-msft
as code owners
seanmcc-msft
approved these changes
May 5, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in Azure#49416.
jaschrep-msft
force-pushed
the
pooledmemstream-testfix
branch
from
fe3b2fa to
4596b5e
Compare
nick863
pushed a commit
that referenced
this pull request
May 8, 2025
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in #49416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a helper method accomplished this. Now, the library uses standard stream-copy APIs, and must remember to also rewind when needed. Fixes live-only test where this rewind was forgotten in #49416.