-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Sync eng/common directory with azure-sdk-tools for PR 12531 #53643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructions.md Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
7afcda7 to
31d5e5f
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new instruction file for running package validation checks on Azure SDK packages. The document provides a workflow for collecting package information from users and executing validation checks via the azsdk_package_run_check tool.
Key Changes
- Introduces a new instruction file
check-package-validation.instructions.mdin theeng/common/instructions/azsdk-tools/directory - Defines a structured workflow for prompting users for package paths and validation check types
- Outlines expected user interaction flow and result presentation
eng/common/instructions/azsdk-tools/check-package-validation.instructions.md
Show resolved
Hide resolved
eng/common/instructions/azsdk-tools/check-package-validation.instructions.md
Show resolved
Hide resolved
eng/common/instructions/azsdk-tools/check-package-validation.instructions.md
Show resolved
Hide resolved
eng/common/instructions/azsdk-tools/check-package-validation.instructions.md
Show resolved
Hide resolved
l0lawrence
approved these changes
Nov 3, 2025
praveenkuttappan
approved these changes
Nov 3, 2025
nick863
pushed a commit
that referenced
this pull request
Nov 5, 2025
* prompt * this * line * update bens suggestions * update * remove try to find pkg path logic * Update eng/common/instructions/azsdk-tools/check-package-validation.instructions.md Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * path * updates * list numbering incorrect * linting --------- Co-authored-by: l0lawrence <llawrence@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Central-EngSys
This issue is owned by the Engineering System team.
EngSys
This issue is impacting the engineering system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12531 See eng/common workflow