-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Sync eng/common directory with azure-sdk-tools for PR 12531 #53643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3f1a0ea
prompt
l0lawrence 3d3837d
this
l0lawrence b8c5491
line
l0lawrence 2fe05ba
update bens suggestions
l0lawrence 0eb2df7
update
l0lawrence 20c717e
remove try to find pkg path logic
l0lawrence 5d331d8
Update eng/common/instructions/azsdk-tools/check-package-validation.i…
l0lawrence 8f9b67f
path
l0lawrence 6ce85c8
updates
l0lawrence 85eddc8
list numbering incorrect
l0lawrence 31d5e5f
linting
l0lawrence File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
eng/common/instructions/azsdk-tools/check-package-validation.instructions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| description: 'Run the package validation checks for the SDK package.' | ||
| --- | ||
| ## Goal | ||
| Run the validation checks for the SDK package by collecting the required information from the user and executing the `azsdk_package_run_check` tool. | ||
|
|
||
| ## Instructions | ||
| 1. **Collect Required Information**: | ||
| - Prompt the user for the absolute package path to the package directory for the SDK package they want to check. | ||
| - Prompt the user to specify values for each of the parameters required by the azsdk_package_run_check tool. Present the user with options to pick from for the allowed values specified by the parameter schema. | ||
l0lawrence marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| 2. **Execute Check**: | ||
| - Use the `azsdk_package_run_check` tool with the package path and check type. | ||
l0lawrence marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| 3. **Present Results**: | ||
| - If the package has passed all validation checks, highlight and finish | ||
| - If the package is not ready, display the specific check types that need to be fixed for each language. | ||
l0lawrence marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Expected User Interaction Flow | ||
| 1. Ask: "What is the exact path of the package you want to check for validation?" | ||
| 2. Ask: "Please specify the check type you want to run (e.g., 'all', 'linting', 'format', etc.)" | ||
| 3. Execute the check using the provided information | ||
| 4. Display results and next steps | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.